Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should simplesearch be compatible with IE11/older versions of Edge? #159

Open
ChrisWilcox78 opened this issue May 29, 2018 · 1 comment
Open

Comments

@ChrisWilcox78
Copy link
Contributor

Hi,

We've run into an issue when using the simplesearch plugin on IE11 and older versions of Edge: these browsers don't support foreach on a NodeList (as employed here). Moreover, it seems that this means that all of our js doesn't load on these browsers if we choose to pipeline the js.

Are these browsers meant to be supported by this plugin (or is there another strategy we should be employing to address the lack of support)?

@ththompson
Copy link

I found a simple work around. The form part still works, it just misses sending to the fancy URL. The following rewrite will get you there

RewriteCond %{QUERY_STRING} searchfield=(.*)
RewriteRule ^(.*) /search/query:%1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants