Skip to content

Commit f14eba9

Browse files
committed
Allow linting in parallel
1 parent 3b53d97 commit f14eba9

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,17 @@ jobs:
4040
with:
4141
fetch-depth: 0
4242

43-
- name: Set git user to getsentry-bot
44-
if: github.ref == 'refs/heads/master'
45-
run: |
46-
echo "GIT_COMMITTER_NAME=getsentry-bot" >> $GITHUB_ENV;
47-
echo "GIT_AUTHOR_NAME=getsentry-bot" >> $GITHUB_ENV;
48-
echo "[email protected]" >> $GITHUB_ENV;
49-
5043
- name: Evaluate docker tag
5144
run: |
5245
if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
5346
echo "DOCKER_TAG=master" >> $GITHUB_ENV
5447
yarn set-docker-tag master
5548
5649
if ! git diff --quiet action.yml; then
50+
echo "GIT_COMMITTER_NAME=getsentry-bot" >> $GITHUB_ENV;
51+
echo "GIT_AUTHOR_NAME=getsentry-bot" >> $GITHUB_ENV;
52+
echo "[email protected]" >> $GITHUB_ENV;
53+
5754
git add action.yml
5855
git commit -m "chore: Set docker tag for master [skip-ci]"
5956
git push
@@ -102,7 +99,6 @@ jobs:
10299
build-args: BUILDKIT_INLINE_CACHE=1
103100

104101
lint:
105-
needs: docker-build
106102
runs-on: ubuntu-latest
107103

108104
steps:

action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ runs:
8888

8989
# For actions running on macos or windows runners, we use a composite
9090
# action approach which allows us to install the arch specific sentry-cli
91-
# binary that's needed for the runner. This is slower.
91+
# binary that's needed for the runner.
92+
# This is slower than the docker approach but runs on macos and windows.
9293
- name: Mark GitHub workspace a safe directory in git
9394
if: ${{ (runner.os == 'macOS' || runner.os == 'Windows') && inputs.disable_safe_directory != 'true' }}
9495
shell: bash

0 commit comments

Comments
 (0)