Skip to content

Action fails with ARM architecture #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lbajsarowicz opened this issue Mar 23, 2022 · 16 comments · Fixed by #197
Closed

Action fails with ARM architecture #81

lbajsarowicz opened this issue Mar 23, 2022 · 16 comments · Fixed by #197

Comments

@lbajsarowicz
Copy link

Environment

  1. Self-hosted Github Runner on ARM64 architecture

Steps to Reproduce

  1. Add the action to workflow

Expected Result

  1. Workflow executes successfully

Actual Result

image

@armenzg
Copy link
Member

armenzg commented Jul 20, 2022

Hello @lbajsarowicz My apologies on the delay to respond. I just joined the team and we were transitioning on managing this repo.

As an alternative, you may use the sentry-cli directly:
https://docs.sentry.io/product/releases/setup/#notify-sentry
Here's a code snippet that may be close to what you need:

          curl -sL https://sentry.io/get-cli/ | bash
          export SENTRY_RELEASE=$(sentry-cli releases propose-version)
          sentry-cli releases new -p $SENTRY_PROJECT $SENTRY_RELEASE
          sentry-cli releases set-commits $SENTRY_RELEASE --auto
          sentry-cli releases files $SENTRY_RELEASE upload-sourcemaps path-to-sourcemaps-if-applicable
          sentry-cli releases finalize $SENTRY_RELEASE
          sentry-cli releases deploys $SENTRY_RELEASE new -e $SENTRY_ENVIRONMENT

For anyone intending to work on this. I wrote a GH job that cross-compiles to the arm64 architecture that could be the basis for supporting this:
https://github.com/getsentry/snuba/blob/94682dc0d1e3dd4043140bbc36d9d76a7f545d74/.github/workflows/ci.yml#L134-L192

@bbednarek
Copy link
Contributor

@armenzg we are facing the same issue after migration to ARM architecture. When are you planning to support ARM64 architecture?

@armenzg
Copy link
Member

armenzg commented Dec 6, 2022

@armenzg we are facing the same issue after migration to ARM architecture. When are you planning to support ARM64 architecture?

Hi @bbednarek I'm pushing for it. No news at the moment. Using the CLI directly will help you work around this.

@bbednarek
Copy link
Contributor

We moved to Sentry CLI, however it would be great to use official action instead.

Do you have any updates on this? When do you plan to support ARM architecture?

@armenzg
Copy link
Member

armenzg commented Feb 21, 2024

Hi @bbednarek
Sadly, this is not in the plans.

I'm asking around as it's been a while since I moved on from this project a long time ago.

@mmospanenko
Copy link

ARM is almost main arch today, all our runners on ARM instances... and will be great to get this runner working

@bittercoder
Copy link

Just wanted to add my 2 cents that this is really frustrating for our organisation as well - for anyone running github actions self-hosted cost management becomes important, and one of the ways to address that is running arm64 hosts. This works great for everything we use in terms of github actions except for sentry which isn't supporting arm64. It doesn't feel like it would take much work to update the current build to target pushing linux/amd64 and linux/arm64 images.

@mmospanenko
Copy link

yes, @bittercoder, we're having the same pain... only one x86 server (from ~100) in infrastructure and only for Sentry :)

@oxc
Copy link

oxc commented Jun 24, 2024

Now that GitHub supports github-hosted ARM64 runners out of the box, more people will stumble over this. Like me 😢

@noamcohen97
Copy link
Contributor

Until a fix is released, I built the exact same Docker image for ARM64, then created a local version of the action in .github/actions/sentry-action-release-arm64 with the new image. Apart from having to manually maintain the image, this is working fine for me.

@bbednarek
Copy link
Contributor

@noamcohen97 Can you contribute to this repo and add ARM support?

@noamcohen97
Copy link
Contributor

noamcohen97 commented Jun 26, 2024

A multi-arch build for version 1.7.0 is available at my fork: https://github.com/noamcohen97/sentry-action-release
Also - created #197 to handle this for future releases.
Hope it helps

@noamcohen97
Copy link
Contributor

The latest images can now be found in the upstream container registry 🥳
https://github.com/getsentry/action-release/pkgs/container/action-release-image/238133662?tag=latest

@armenzg
Copy link
Member

armenzg commented Jul 2, 2024

Hello folks,
@noamcohen97 contributed a PR for this. Thank you, thank you!!!

Could you all please verify if it's working properly?
Also, please let me know if I need to cut a release or not. I have not looked into this for a very long time.

My apologies on the delay and I hope this works!

@noamcohen97
Copy link
Contributor

I don't think a new release is a must. All version uses the latest tag which was just updated.

@damusnet
Copy link

damusnet commented Jul 9, 2024

datapoint here to say that it works, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants