Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Commit 826a267

Browse files
authored
fix: Keep user in log data if it came from django (#1246)
1 parent 54a6a5f commit 826a267

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

raven/contrib/django/client.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,13 @@ def get_user_info(self, request):
186186
return user_info
187187

188188
def get_data_from_request(self, request):
189-
result = {}
189+
rv = {}
190+
self.update_data_from_request(request, rv)
191+
return rv
190192

191-
result['user'] = self.get_user_info(request)
193+
def update_data_from_request(self, request, result):
194+
if result.get('user') is None:
195+
result['user'] = self.get_user_info(request)
192196

193197
try:
194198
uri = request.build_absolute_uri()
@@ -236,8 +240,6 @@ def get_data_from_request(self, request):
236240
}
237241
})
238242

239-
return result
240-
241243
def build_msg(self, *args, **kwargs):
242244
data = super(DjangoClient, self).build_msg(*args, **kwargs)
243245

@@ -266,7 +268,7 @@ def build_msg(self, *args, **kwargs):
266268
return data
267269

268270
def capture(self, event_type, request=None, **kwargs):
269-
if 'data' not in kwargs:
271+
if kwargs.get('data') is None:
270272
kwargs['data'] = data = {}
271273
else:
272274
data = kwargs['data']
@@ -276,7 +278,7 @@ def capture(self, event_type, request=None, **kwargs):
276278

277279
is_http_request = isinstance(request, HttpRequest)
278280
if is_http_request:
279-
data.update(self.get_data_from_request(request))
281+
self.update_data_from_request(request, data)
280282

281283
if kwargs.get('exc_info'):
282284
exc_value = kwargs['exc_info'][1]

0 commit comments

Comments
 (0)