TypeError in breadcrumbs for botocore

[Daenyth]

TypeError: getresponse() got an unexpected keyword argument 'buffering'
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 372, in _make_request
    httplib_response = conn.getresponse(buffering=True)
  File "raven/breadcrumbs.py", line 346, in getresponse
    rv = real_getresponse(self, *args, **kwargs)

I see this in my sentry - it seems to happen when there's a connection error.

full exception info

TypeError: getresponse() got an unexpected keyword argument 'buffering'
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 372, in _make_request
    httplib_response = conn.getresponse(buffering=True)
  File "raven/breadcrumbs.py", line 346, in getresponse
    rv = real_getresponse(self, *args, **kwargs)
ConnectionResetError: [Errno 104] Connection reset by peer
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
    body=body, headers=headers)
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 374, in _make_request
    httplib_response = conn.getresponse()
  File "raven/breadcrumbs.py", line 346, in getresponse
    rv = real_getresponse(self, *args, **kwargs)
  File "http/client.py", line 1331, in getresponse
    response.begin()
  File "http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "python3.6/socket.py", line 586, in readinto
    return self._sock.recv_into(b)
ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
  File "botocore/vendored/requests/adapters.py", line 370, in send
    timeout=timeout
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 597, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "botocore/vendored/requests/packages/urllib3/util/retry.py", line 245, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "botocore/vendored/requests/packages/urllib3/packages/six.py", line 309, in reraise
    raise value.with_traceback(tb)
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
    body=body, headers=headers)
  File "botocore/vendored/requests/packages/urllib3/connectionpool.py", line 374, in _make_request
    httplib_response = conn.getresponse()
  File "raven/breadcrumbs.py", line 346, in getresponse
    rv = real_getresponse(self, *args, **kwargs)
  File "http/client.py", line 1331, in getresponse
    response.begin()
  File "http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "python3.6/socket.py", line 586, in readinto
    return self._sock.recv_into(b)
ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
  File "python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "s3_uploader/__main__.py", line 137, in <module>
    bucket_list = list(s3_client.s3.buckets.all())
  File "boto3/resources/collection.py", line 83, in __iter__
    for page in self.pages():
  File "boto3/resources/collection.py", line 161, in pages
    pages = [getattr(client, self._py_operation_name)(**params)]
  File "botocore/client.py", line 310, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "botocore/client.py", line 586, in _make_api_call
    operation_model, request_dict)
  File "botocore/endpoint.py", line 141, in make_request
    return self._send_request(request_dict, operation_model)
  File "botocore/endpoint.py", line 170, in _send_request
    success_response, exception):
  File "botocore/endpoint.py", line 249, in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
  File "botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "botocore/retryhandler.py", line 251, in __call__
    caught_exception)
  File "botocore/retryhandler.py", line 277, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "botocore/retryhandler.py", line 317, in __call__
    caught_exception)
  File "botocore/retryhandler.py", line 223, in __call__
    attempt_number, caught_exception)
  File "botocore/retryhandler.py", line 359, in _check_caught_exception
    raise caught_exception
  File "botocore/endpoint.py", line 204, in _get_response
    proxies=self.proxies, timeout=self.timeout)
  File "botocore/vendored/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "botocore/vendored/requests/adapters.py", line 415, in send
    raise ConnectionError(err, request=request)

Using:
Python 3.6.1
raven==6.1.0
botocore==1.5.80

[cjerdonek]

I wonder if an old version of urllib3 was being used. It seems urllib3 fixed it not to show "TypeError: getresponse() got an unexpected keyword argument 'buffering'" starting with urllib3 1.16: urllib3/urllib3#861

[cjerdonek]

(I don't think I clicked anything to unassign @ashwoods, btw.)