Skip to content

Commit c1c007c

Browse files
committed
Remove redundant comments in tombstone parser test
1 parent ea41fe2 commit c1c007c

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

sentry-android-core/src/test/java/io/sentry/android/core/internal/tombstone/TombstoneParserTest.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ class TombstoneParserTest {
100100

101101
// threads
102102
assertEquals(62, event.threads!!.size)
103-
104-
// exactly one thread is the main thread (its id equals the process id, 21891) and its name is
105-
// normalized to "main"
106103
val mainThread = event.threads!!.single { it.isMain == true }
107104
assertEquals(21891, mainThread.id)
108105
assertEquals("main", mainThread.name)
@@ -407,10 +404,6 @@ class TombstoneParserTest {
407404

408405
@Test
409406
fun `identifies the main thread via pid matching the thread id and normalizes its name`() {
410-
// On Linux/Android the main thread's kernel thread id equals the process id (pid), so we use
411-
// that to detect the main thread even when the OS renamed it to the (truncated) process name.
412-
// The crashed thread (tid) is a different thread here to verify the two are handled
413-
// independently.
414407
val tombstone =
415408
Tombstone.Builder()
416409
.pid(1000)
@@ -430,7 +423,6 @@ class TombstoneParserTest {
430423
0,
431424
)
432425
)
433-
// crashed thread: id == tid
434426
.addThread(
435427
TombstoneThread(
436428
2000,
@@ -444,7 +436,6 @@ class TombstoneParserTest {
444436
0,
445437
)
446438
)
447-
// background thread: neither main nor crashed
448439
.addThread(
449440
TombstoneThread(
450441
3000,
@@ -465,7 +456,6 @@ class TombstoneParserTest {
465456

466457
val main = threads.single { it.isMain == true }
467458
assertEquals(1000, main.id)
468-
// the OS-assigned process name is normalized back to "main"
469459
assertEquals("main", main.name)
470460

471461
val crashed = threads.single { it.isCrashed == true }

0 commit comments

Comments
 (0)