Refactor e2e test cleanup and temporary directory handling

Replaced inline `rimraf` calls with a dedicated `clean.ts` script for better maintainability. Standardized temporary directory management by introducing a consistent prefix and leveraging `path.basename` for clarity. These changes improve code organization and simplify future modifications.

Author: cod1k

dev-packages/e2e-tests/clean.ts

@@ -0,0 +1,7 @@
+import { tmpdir } from 'os';
+import { join } from 'path';
+import { rimrafSync } from 'rimraf';
+
+const buildDir = join(tmpdir(), 'sentry-e2e-tests-*');
+
+process.exit(Number(!rimrafSync([...process.argv.slice(2), buildDir], { glob: true })));

dev-packages/e2e-tests/package.json

@@ -13,7 +13,7 @@
     "test:validate-test-app-setups": "ts-node validate-test-app-setups.ts",
     "test:prepare": "ts-node prepare.ts",
     "test:validate": "run-s test:validate-configuration test:validate-test-app-setups",
-    "clean": "rimraf tmp node_modules && yarn clean:test-applications && yarn clean:pnpm",
+    "clean": "ts-node ./clean.ts node_modules && yarn clean:test-applications && yarn clean:pnpm",
     "ci:build-matrix": "ts-node ./lib/getTestMatrix.ts",
     "ci:build-matrix-optional": "ts-node ./lib/getTestMatrix.ts --optional=true",
     "ci:copy-to-temp": "ts-node ./ciCopyToTemp.ts",

dev-packages/e2e-tests/run.ts

@@ -4,7 +4,8 @@ import * as dotenv from 'dotenv';
 import { mkdtemp, rm } from 'fs/promises';
 import { sync as globSync } from 'glob';
 import { tmpdir } from 'os';
-import { join, resolve } from 'path';
+import { basename, join, resolve } from 'path';
+import { rimraf } from 'rimraf';
 import { copyToTemp } from './lib/copyToTemp';
 import { registrySetup } from './registrySetup';
 
@@ -56,6 +57,9 @@ async function run(): Promise<void> {
     console.log('Cleaning test-applications...');
     console.log('');
 
+    const tmpPrefix = join(tmpdir(), 'sentry-e2e-tests-')
+    await rimraf(`${tmpPrefix}*`, { glob: true });
+
     if (!process.env.SKIP_REGISTRY) {
       registrySetup();
     }
@@ -68,8 +72,8 @@ async function run(): Promise<void> {
     console.log('');
 
     for (const testAppPath of testAppPaths) {
-      const originalPath = resolve('test-applications', testAppPath);
-      const tmpDirPath = await mkdtemp(join(tmpdir(), `sentry-e2e-tests-${appName}-`));
+      const originalPath = resolve(__dirname, 'test-applications', testAppPath);
+      const tmpDirPath = await mkdtemp(`${tmpPrefix}${basename(testAppPath)}-`);
 
       await copyToTemp(originalPath, tmpDirPath);
       const cwd = tmpDirPath;