Skip to content

fix(react-router): Ensure that all browser spans have source=route #16984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

fix(react-router): Ensure that all browser spans have source=route #16984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d6a52
feat(react-router): Ensure that all browser spans have `source=route`
mydea Jul 14, 2025
b6ca6fa
fix e2e test
mydea Jul 14, 2025
4dda614
fix tests
mydea Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-applications/react-router-7-framework-custom/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test.describe('client - navigation performance', () => {
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
Expand All @@ -33,7 +33,7 @@ test.describe('client - navigation performance', () => {
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
Expand Down
26 changes: 13 additions & 13 deletions ...st-applications/react-router-7-framework-custom/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/';
return transactionEvent.transaction === '/performance';
});

await page.goto(`/performance`);
Expand All @@ -18,20 +18,20 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/',
transaction: '/performance',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
Expand Down Expand Up @@ -68,12 +68,12 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
Expand Down Expand Up @@ -105,26 +105,26 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static/';
return transactionEvent.transaction === '/performance/static';
});

await page.goto(`/performance/static`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
transaction: '/performance/static/',
transaction: '/performance/static',
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
});
Expand Down
4 changes: 2 additions & 2 deletions ...lications/react-router-7-framework-node-20-18/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test.describe('client - navigation performance', () => {
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
Expand All @@ -33,7 +33,7 @@ test.describe('client - navigation performance', () => {
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
Expand Down
26 changes: 13 additions & 13 deletions ...pplications/react-router-7-framework-node-20-18/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/';
return transactionEvent.transaction === '/performance';
});

await page.goto(`/performance`);
Expand All @@ -18,20 +18,20 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/',
transaction: '/performance',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
Expand Down Expand Up @@ -68,12 +68,12 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
Expand Down Expand Up @@ -105,26 +105,26 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static/';
return transactionEvent.transaction === '/performance/static';
});

await page.goto(`/performance/static`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
transaction: '/performance/static/',
transaction: '/performance/static',
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
});
Expand Down
12 changes: 6 additions & 6 deletions ...cations/react-router-7-framework-spa-node-20-18/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
Expand Down Expand Up @@ -68,12 +68,12 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
Expand Down
12 changes: 6 additions & 6 deletions .../test-applications/react-router-7-framework-spa/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
Expand Down Expand Up @@ -68,12 +68,12 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
Expand Down
4 changes: 2 additions & 2 deletions ...ts/test-applications/react-router-7-framework/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test.describe('client - navigation performance', () => {
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
Expand All @@ -33,7 +33,7 @@ test.describe('client - navigation performance', () => {
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
Expand Down
26 changes: 13 additions & 13 deletions ...ests/test-applications/react-router-7-framework/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/';
return transactionEvent.transaction === '/performance';
});

await page.goto(`/performance`);
Expand All @@ -18,20 +18,20 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/',
transaction: '/performance',
type: 'transaction',
transaction_info: { source: 'url' },
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
Expand Down Expand Up @@ -68,12 +68,12 @@ test.describe('client - pageload performance', () => {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
spans: expect.any(Array),
Expand Down Expand Up @@ -105,26 +105,26 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static/';
return transactionEvent.transaction === '/performance/static';
});

await page.goto(`/performance/static`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
transaction: '/performance/static/',
transaction: '/performance/static',
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.origin': 'auto.pageload.react-router',
'sentry.op': 'pageload',
'sentry.source': 'url',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
origin: 'auto.pageload.react-router',
},
},
});
Expand Down
Loading
Loading