diff --git a/dev-packages/browser-integration-tests/suites/replay/autoFlushOnFeedback/init.js b/dev-packages/browser-integration-tests/suites/replay/autoFlushOnFeedback/init.js index ecbfac30016e..7b73a029761d 100644 --- a/dev-packages/browser-integration-tests/suites/replay/autoFlushOnFeedback/init.js +++ b/dev-packages/browser-integration-tests/suites/replay/autoFlushOnFeedback/init.js @@ -5,9 +5,6 @@ window.Replay = Sentry.replayIntegration({ flushMinDelay: 200, flushMaxDelay: 200, useCompression: false, - _experiments: { - autoFlushOnFeedback: true, - }, }); Sentry.init({ diff --git a/packages/replay-internal/src/replay.ts b/packages/replay-internal/src/replay.ts index 8bfebcbda173..ae3aa9589cab 100644 --- a/packages/replay-internal/src/replay.ts +++ b/packages/replay-internal/src/replay.ts @@ -939,7 +939,7 @@ export class ReplayContainer implements ReplayContainerInterface { // There is no way to remove these listeners, so ensure they are only added once if (!this._hasInitializedCoreListeners) { - addGlobalListeners(this, { autoFlushOnFeedback: this._options._experiments.autoFlushOnFeedback }); + addGlobalListeners(this); this._hasInitializedCoreListeners = true; } diff --git a/packages/replay-internal/src/types/replay.ts b/packages/replay-internal/src/types/replay.ts index 68ee0d749067..98f61da231c6 100644 --- a/packages/replay-internal/src/types/replay.ts +++ b/packages/replay-internal/src/types/replay.ts @@ -235,6 +235,9 @@ export interface ReplayPluginOptions extends ReplayNetworkOptions { * https://github.com/rrweb-io/rrweb/blob/master/docs/recipes/cross-origin-iframes.md#considerations */ recordCrossOriginIframes: boolean; + /** + * @deprecated This option is now the default behavior and the option is no longer needed. It will be removed in the next major version. + */ autoFlushOnFeedback: boolean; /** * Completetly ignore mutations matching the given selectors. diff --git a/packages/replay-internal/src/util/addGlobalListeners.ts b/packages/replay-internal/src/util/addGlobalListeners.ts index 530749c6e3f7..cd5c141d0160 100644 --- a/packages/replay-internal/src/util/addGlobalListeners.ts +++ b/packages/replay-internal/src/util/addGlobalListeners.ts @@ -16,10 +16,7 @@ import type { ReplayContainer } from '../types'; /** * Add global listeners that cannot be removed. */ -export function addGlobalListeners( - replay: ReplayContainer, - { autoFlushOnFeedback }: { autoFlushOnFeedback?: boolean }, -): void { +export function addGlobalListeners(replay: ReplayContainer): void { // Listeners from core SDK // const client = getClient(); @@ -64,17 +61,15 @@ export function addGlobalListeners( const replayId = replay.getSessionId(); if (options?.includeReplay && replay.isEnabled() && replayId && feedbackEvent.contexts?.feedback) { // In case the feedback is sent via API and not through our widget, we want to flush replay - if (feedbackEvent.contexts.feedback.source === 'api' && autoFlushOnFeedback) { + if (feedbackEvent.contexts.feedback.source === 'api') { await replay.flush(); } feedbackEvent.contexts.feedback.replay_id = replayId; } }); - if (autoFlushOnFeedback) { - client.on('openFeedbackWidget', async () => { - await replay.flush(); - }); - } + client.on('openFeedbackWidget', async () => { + await replay.flush(); + }); } }