-
-
Notifications
You must be signed in to change notification settings - Fork 188
Collecting breadcrumbs in notifications causes TypeError #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Interesting, I wasn't aware that was possible but looking closer at the code the notifiable can be anything, so I submitted #974 to fix this error. |
@stayallive Yes. It can be anything that the notification channel class can work with. Thank you |
With 4.12.0 that was just released this should now be solved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How do you use Sentry?
Self-hosted / on-premises
SDK version
4.10.1
Laravel version
10.48
Steps to reproduce
breadcrumbs.notifications
in configNotification::send('someidentificator', new SomeNotification())
(I send notification to messenger via channel name)Expected result
No errors
Actual result
TypeError
Sentry\Laravel\Features\NotificationsIntegration::formatNotifiable(): Argument #1 ($notifiable) must be of type object, string given, called in .../vendor/sentry/sentry-laravel/src/Sentry/Laravel/Features/NotificationsIntegration.php on line 72
during handling theNotificationSent
eventThe text was updated successfully, but these errors were encountered: