Move OTel code out of integrations/
#3853
Assignees
Comments
This was referenced Apr 9, 2025
sentrivana
added a commit
that referenced
this issue
Apr 10, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This moves `sentry_sdk/integrations/opentelemetry/sampler.py` -> `sentry_sdk/opentelemetry/sampler.py` Ref #3853
This was referenced Apr 10, 2025
sentrivana
added a commit
that referenced
this issue
Apr 10, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This moves `sentry_sdk/integrations/opentelemetry/span_processor.py` -> `sentry_sdk/opentelemetry/span_processor.py` Ref #3853 --------- Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentrivana
added a commit
that referenced
this issue
Apr 10, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This moves `sentry_sdk/integrations/opentelemetry/propagator.py` -> `sentry_sdk/opentelemetry/propagator.py` Ref #3853 --------- Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentrivana
added a commit
that referenced
this issue
Apr 10, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This moves `sentry_sdk/integrations/opentelemetry/contextvars_context.py` -> `sentry_sdk/opentelemetry/contextvars_context.py` Ref #3853
sentrivana
added a commit
that referenced
this issue
Apr 14, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since
there is no OpenTelemetry integration anymore -- it's part of the core
SDK. This moves
`sentry_sdk/integrations/opentelemetry/{utils,consts}.py` ->
`sentry_sdk/opentelemetry/{utils,consts}.py`.
There's quite some stuff moving around in this PR in order to remove
circular dependencies that have to do with `tracing.py`:
- `get_span_status_from_http_code` from `tracing.py` is now in
`tracing_utils.py`
- various constants from `tracing.py` are now in `consts.py`
Additionally, Sphinx was unhappy, so tweaked the way we type some things
in `api.py` and `_init_implementation.py`.
I'll possibly follow this up with creating a nice structure for the
tracing files, maybe a common `tracing` directory with `tracing.py`,
`tracing_utils.py` -> `utils.py`, and dedicated `consts.py`.
Ref #3853
sentrivana
added a commit
that referenced
this issue
Apr 14, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This moves `sentry_sdk/integrations/opentelemetry/scope.py` -> `sentry_sdk/opentelemetry/scope.py` Ref #3853
antonpirker
assigned antonpirker and sentrivana and unassigned sentrivana and antonpirker
sentrivana
added a commit
that referenced
this issue
Apr 15, 2025
Moving stuff out of `integrations/opentelemetry/` step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. - Moved `sentry_sdk/integrations/opentelemetry/integration.py` -> `sentry_sdk/opentelemetry/tracing.py`. - Removed all the experimental autoinstrumentation stuff from `integration.py`. - Removed `integrations/opentelemetry/` altogether (there was nothing left but `__init__.py`, which is now also gone). - Moved all tests from `tests/integrations/opentelemetry` to `tests/opentelemetry`. - Removed the potel/opentelemetry integration test targets from `tox.ini`. These will now be run as part of the Common test suite. Ref #3853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, POTel is written as an integration. This is problematic since it can be disabled via
default_integrations=False. Also in architectural sense it's no longer an integration but an integral part of the SDK, so it's time for it to move out of theintegrations/directory.This should also enable us to clean up the code and get rid of some inline imports due to circular imports.
Consider not breaking people importing the processor/propagator by reexporting it in the old place. Also add a message, maybe.
integrations/opentelemetry/#4258integrations/opentelemetry/#4259integrations/opentelemetry/#4260integrations/opentelemetry/#4272integrations/opentelemetry/#4276integrations/opentelemetry/#4277The text was updated successfully, but these errors were encountered: