fix(feedback): Guard show/hide against uninitialized _setVisibility (#6435)

* fix(feedback): Guard show/hide against uninitialized _setVisibility

When Sentry.showFeedbackForm() (or the equivalent Button/Screenshot
show/hide) is called before FeedbackFormProvider has mounted and run
initialize(), the static _setVisibility was undefined. The guard
`_setVisibility !== NOOP_SET_VISIBILITY` evaluated true and the code
called undefined(true), throwing TypeError.

Default the static field to NOOP_SET_VISIBILITY at declaration so the
guard correctly falls through to the intended console.warn fallback.

Fixes SDK-CRASHES-REACT-NATIVE-62C

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs: Add CHANGELOG entry for #6435

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Alexander <alex@apantiukhov.com>

Author: 3 people

CHANGELOG.md

@@ -14,6 +14,7 @@
 
 ### Fixes
 
+- Fix `TypeError` when `showFeedbackForm`/`showFeedbackButton`/`showScreenshotButton` is called before `FeedbackFormProvider` mounts ([#6435](https://github.com/getsentry/sentry-react-native/pull/6435))
 - Fix orphaned TTID/TTFD spans in the trace view ([#6437](https://github.com/getsentry/sentry-react-native/pull/6437))
 
 ## 8.18.0

packages/core/src/js/feedback/FeedbackFormManager.tsx

@@ -19,7 +19,9 @@ const NOOP_SET_VISIBILITY = (): void => {
 
 abstract class FeedbackManager {
   protected static _isVisible = false;
-  protected static _setVisibility: (visible: boolean) => void;
+  // Default to NOOP so `show()`/`hide()` don't call `undefined(...)` when
+  // invoked before `FeedbackFormProvider` mounts and calls `initialize()`.
+  protected static _setVisibility: (visible: boolean) => void = NOOP_SET_VISIBILITY;
 
   protected static get _feedbackComponentName(): string {
     throw new Error('Subclasses must override feedbackComponentName');

packages/core/test/feedback/FeedbackFormManager.test.tsx

@@ -87,6 +87,29 @@ describe('FeedbackFormManager', () => {
     }).not.toThrow();
   });
 
+  it('showFeedbackForm does not throw before any provider or reset has run', () => {
+    // Regression for SDK-CRASHES-REACT-NATIVE-62C: `_setVisibility` used to be
+    // uninitialized, so calling show() before FeedbackFormProvider mounted threw
+    // `TypeError: this._setVisibility is not a function`. Load the module fresh
+    // so the class statics have never been touched by other tests.
+    jest.isolateModules(() => {
+      // eslint-disable-next-line @typescript-eslint/no-require-imports
+      const freshManager = require('../../src/js/feedback/FeedbackFormManager');
+      expect(() => freshManager.showFeedbackForm()).not.toThrow();
+      expect(consoleWarnSpy).toHaveBeenCalledWith(expect.stringContaining("requires 'Sentry.wrap(RootComponent)'"));
+    });
+  });
+
+  it('hideFeedbackForm does not throw before any provider or reset has run', () => {
+    // Symmetric to show(): hide() reads the same uninitialized static field.
+    jest.isolateModules(() => {
+      // eslint-disable-next-line @typescript-eslint/no-require-imports
+      const freshManager = require('../../src/js/feedback/FeedbackFormManager');
+      expect(() => freshManager.FeedbackFormManager.hide()).not.toThrow();
+      expect(consoleWarnSpy).toHaveBeenCalledWith(expect.stringContaining("requires 'Sentry.wrap(RootComponent)'"));
+    });
+  });
+
   it('showFeedbackForm displays the form with the feedbackIntegration options', async () => {
     mockedIsModalSupported.mockReturnValue(true);
     const { getByPlaceholderText, getByText } = render(