ref(flags): Remove quoted flags syntax from grammar (#93619)

Depends on: #93616

Author: cmanallen

src/sentry/api/event_search.py

@@ -140,15 +140,9 @@
 
 # the quoted variant is here to for backwards compatibility,
 # and can be removed once we're sure it's no longer in use
-explicit_flag_key_unquoted         = "flags" open_bracket escaped_key closed_bracket
-explicit_flag_key_quoted           = "flags" open_bracket quoted_key closed_bracket
-explicit_flag_key                  = explicit_flag_key_unquoted / explicit_flag_key_quoted
-explicit_string_flag_key_unquoted  = "flags" open_bracket escaped_key spaces comma spaces "string" closed_bracket
-explicit_string_flag_key_quoted    = "flags" open_bracket quoted_key spaces comma spaces "string" closed_bracket
-explicit_string_flag_key           = explicit_string_flag_key_unquoted / explicit_string_flag_key_quoted
-explicit_number_flag_key_unquoted  = "flags" open_bracket escaped_key spaces comma spaces "number" closed_bracket
-explicit_number_flag_key_quoted    = "flags" open_bracket quoted_key spaces comma spaces "number" closed_bracket
-explicit_number_flag_key           = explicit_number_flag_key_unquoted  / explicit_number_flag_key_quoted
+explicit_flag_key         = "flags" open_bracket escaped_key closed_bracket
+explicit_string_flag_key  = "flags" open_bracket escaped_key spaces comma spaces "string" closed_bracket
+explicit_number_flag_key  = "flags" open_bracket escaped_key spaces comma spaces "number" closed_bracket
 
 explicit_tag_key        = "tags" open_bracket escaped_key closed_bracket
 explicit_string_tag_key = "tags" open_bracket escaped_key spaces comma spaces "string" closed_bracket
@@ -1408,19 +1402,7 @@ def visit_explicit_number_tag_key(
     ) -> SearchKey:
         return SearchKey(f"tags[{children[2]},number]")
 
-    def visit_explicit_flag_key_unquoted(
-        self,
-        node: Node,
-        children: tuple[
-            Node,  # "flags"
-            str,  # [
-            str,  # escaped_key
-            str,  # ]
-        ],
-    ) -> SearchKey:
-        return SearchKey(f"flags[{children[2]}]")
-
-    def visit_explicit_flag_key_quoted(
+    def visit_explicit_flag_key(
         self,
         node: Node,
         children: tuple[
@@ -1432,30 +1414,7 @@ def visit_explicit_flag_key_quoted(
     ) -> SearchKey:
         return SearchKey(f"flags[{children[2]}]")
 
-    def visit_explicit_flag_key(
-        self,
-        node: Node,
-        children: tuple[SearchKey],
-    ) -> SearchKey:
-        return children[0]
-
-    def visit_explicit_string_flag_key_unquoted(
-        self,
-        node: Node,
-        children: tuple[
-            Node,  # "flags"
-            str,  # '['
-            str,  # escaped_key
-            str,  # ' '
-            Node,  # ','
-            str,  # ' '
-            Node,  # "string"
-            str,  # ']'
-        ],
-    ) -> SearchKey:
-        return SearchKey(f"flags[{children[2]},string]")
-
-    def visit_explicit_string_flag_key_quoted(
+    def visit_explicit_string_flag_key(
         self,
         node: Node,
         children: tuple[
@@ -1471,30 +1430,7 @@ def visit_explicit_string_flag_key_quoted(
     ) -> SearchKey:
         return SearchKey(f"flags[{children[2]},string]")
 
-    def visit_explicit_string_flag_key(
-        self,
-        node: Node,
-        children: tuple[SearchKey],
-    ) -> SearchKey:
-        return children[0]
-
-    def visit_explicit_number_flag_key_unquoted(
-        self,
-        node: Node,
-        children: tuple[
-            Node,  # "flags"
-            str,  # '['
-            str,  # escaped_key
-            str,  # ' '
-            Node,  # ','
-            str,  # ' '
-            Node,  # "number"
-            str,  # ']'
-        ],
-    ) -> SearchKey:
-        return SearchKey(f"flags[{children[2]},number]")
-
-    def visit_explicit_number_flag_key_quoted(
+    def visit_explicit_number_flag_key(
         self,
         node: Node,
         children: tuple[
@@ -1510,13 +1446,6 @@ def visit_explicit_number_flag_key_quoted(
     ) -> SearchKey:
         return SearchKey(f"flags[{children[2]},number]")
 
-    def visit_explicit_number_flag_key(
-        self,
-        node: Node,
-        children: tuple[SearchKey],
-    ) -> SearchKey:
-        return children[0]
-
     def visit_aggregate_key(
         self,
         node: Node,

tests/sentry/api/test_event_search.py

@@ -1072,12 +1072,6 @@ def test_invalid_translate_wildcard_as_clickhouse_pattern(pattern):
         pytest.param("flags[foo:bar,string]:true", "flags[foo:bar,string]", "true"),
         pytest.param("flags[foo,number]:0", "flags[foo,number]", "0"),
         pytest.param("flags[foo:bar,number]:0", "flags[foo:bar,number]", "0"),
-        # the quoted versions are supported for flags for backwards compatibility
-        pytest.param('flags["foo"]:true', "flags[foo]", "true"),
-        pytest.param('flags["foo",string]:true', "flags[foo,string]", "true"),
-        pytest.param('flags["foo:bar",string]:true', "flags[foo:bar,string]", "true"),
-        pytest.param('flags["foo",number]:0', "flags[foo,number]", "0"),
-        pytest.param('flags["foo:bar",number]:0', "flags[foo:bar,number]", "0"),
     ],
 )
 def test_handles_special_character_in_tags_and_flags(query, key, value):

tests/sentry/issues/endpoints/test_organization_group_index.py

@@ -4051,15 +4051,15 @@ def test_flags_and_tags_query(self, _: MagicMock) -> None:
         )
 
         with self.feature({"organizations:issue-search-snuba": False}):
-            response = self.get_success_response(query='flags["test:flag"]:true')
+            response = self.get_success_response(query="flags[test:flag]:true")
             assert len(json.loads(response.content)) == 1
-            response = self.get_success_response(query='flags["test:flag"]:false')
+            response = self.get_success_response(query="flags[test:flag]:false")
             assert len(json.loads(response.content)) == 0
 
         with self.feature({"organizations:issue-search-snuba": True}):
-            response = self.get_success_response(query='flags["test:flag"]:true')
+            response = self.get_success_response(query="flags[test:flag]:true")
             assert len(json.loads(response.content)) == 1
-            response = self.get_success_response(query='flags["test:flag"]:false')
+            response = self.get_success_response(query="flags[test:flag]:false")
             assert len(json.loads(response.content)) == 0
 
     def test_postgres_query_timeout(self, mock_query: MagicMock) -> None:

tests/sentry/issues/endpoints/test_organization_issues_count.py

@@ -28,6 +28,6 @@ def test_issue_count_flag_query(self) -> None:
             project_id=self.project.id,
         )
 
-        response = self.client.get(self.url + '?query=flags["test:flag"]:true')
+        response = self.client.get(self.url + "?query=flags[test:flag]:true")
         assert response.status_code == 200
-        assert response.json() == {'flags["test:flag"]:true': 1}
+        assert response.json() == {"flags[test:flag]:true": 1}