Skip to content

Commit 6dda344

Browse files
Zylphrexandrewshie-sentry
authored andcommitted
styles(explore): Fix aggregate column editor dropdown width (#93326)
| Before | After | | -------|------| | ![image](https://github.com/user-attachments/assets/902c63c9-4628-49ec-94ff-fcb25baaa6dd) | ![image](https://github.com/user-attachments/assets/c6cfcb5e-9d90-4774-934d-26667f006f0e) |
1 parent bc5c668 commit 6dda344

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

static/app/views/explore/tables/aggregateColumnEditorModal.tsx

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ function GroupBySelector({
236236
);
237237

238238
return (
239-
<StyledCompactSelect
239+
<SingleWidthCompactSelect
240240
data-test-id="editor-groupby"
241241
options={options}
242242
triggerLabel={label}
@@ -307,7 +307,7 @@ function VisualizeSelector({
307307

308308
return (
309309
<Fragment>
310-
<StyledCompactSelect
310+
<SingleWidthCompactSelect
311311
data-test-id="editor-visualize-function"
312312
options={aggregateOptions}
313313
value={parsedFunction?.name}
@@ -320,7 +320,7 @@ function VisualizeSelector({
320320
},
321321
}}
322322
/>
323-
<StyledCompactSelect
323+
<DoubleWidthCompactSelect
324324
data-test-id="editor-visualize-argument"
325325
options={argumentOptions}
326326
value={parsedFunction?.arguments[0] ?? ''}
@@ -353,8 +353,13 @@ const StyledButton = styled(Button)`
353353
padding-right: 0;
354354
`;
355355

356-
const StyledCompactSelect = styled(CompactSelect)`
357-
flex-grow: 1;
356+
const SingleWidthCompactSelect = styled(CompactSelect)`
357+
flex: 1;
358+
min-width: 0;
359+
`;
360+
361+
const DoubleWidthCompactSelect = styled(CompactSelect)`
362+
flex: 2;
358363
min-width: 0;
359364
`;
360365

0 commit comments

Comments
 (0)