Skip to content

Commit d36be7d

Browse files
authored
fix(aci): add enabled field to detector/workflow serializers (#93678)
need the `enabled` field for the UI
1 parent 36f5bba commit d36be7d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/sentry/workflow_engine/endpoints/serializers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ def serialize(self, obj: Detector, attrs: Mapping[str, Any], user, **kwargs) ->
347347
"dataSources": attrs.get("data_sources"),
348348
"conditionGroup": attrs.get("condition_group"),
349349
"config": attrs.get("config"),
350+
"enabled": obj.enabled,
350351
}
351352

352353

@@ -407,6 +408,7 @@ def serialize(self, obj: Workflow, attrs: Mapping[str, Any], user, **kwargs) ->
407408
"environment": obj.environment.name if obj.environment else None,
408409
"config": obj.config,
409410
"detectorIds": attrs.get("detectorIds"),
411+
"enabled": obj.enabled,
410412
}
411413

412414

tests/sentry/workflow_engine/endpoints/test_serializers.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def test_serialize_simple(self):
3737
"workflowIds": [],
3838
"config": default_detector_config_data[MetricIssue.slug],
3939
"owner": None,
40+
"enabled": detector.enabled,
4041
}
4142

4243
def test_serialize_full(self):
@@ -146,6 +147,7 @@ def test_serialize_full(self):
146147
"workflowIds": [str(workflow.id)],
147148
"config": default_detector_config_data[MetricIssue.slug],
148149
"owner": self.user.get_actor_identifier(),
150+
"enabled": detector.enabled,
149151
}
150152

151153
def test_serialize_bulk(self):
@@ -374,6 +376,7 @@ def test_serialize_simple(self):
374376
"actionFilters": [],
375377
"environment": None,
376378
"detectorIds": [],
379+
"enabled": workflow.enabled,
377380
}
378381

379382
def test_serialize_full(self):
@@ -477,6 +480,7 @@ def test_serialize_full(self):
477480
],
478481
"environment": self.environment.name,
479482
"detectorIds": [str(detector.id)],
483+
"enabled": workflow.enabled,
480484
}
481485

482486

0 commit comments

Comments
 (0)