File tree Expand file tree Collapse file tree 2 files changed +6
-14
lines changed
src/sentry/middleware/integrations/parsers
tests/sentry/middleware/integrations/parsers Expand file tree Collapse file tree 2 files changed +6
-14
lines changed Original file line number Diff line number Diff line change @@ -61,17 +61,11 @@ def get_response(self):
61
61
regions = self .get_regions_from_organizations ()
62
62
63
63
if len (regions ) == 0 :
64
- logger .info ("%s.no_regions" , self .provider , extra = {"path" : self .request .path })
65
64
return self .get_default_missing_integration_response ()
66
65
67
66
if len (regions ) > 1 :
68
- # Since Jira is region_restricted (see JiraIntegrationProvider) we can just pick the
69
- # first region to forward along to.
70
- logger .info (
71
- "%s.too_many_regions" ,
72
- self .provider ,
73
- extra = {"path" : self .request .path , "regions" : regions },
74
- )
67
+ # This shouldn't happen because we block multi region install at the install time.
68
+ raise ValueError ("Jira integration is installed in multiple regions" )
75
69
76
70
if self .view_class in self .immediate_response_region_classes :
77
71
try :
Original file line number Diff line number Diff line change 2
2
3
3
from unittest .mock import patch
4
4
5
+ import pytest
5
6
import responses
6
7
from django .http import HttpRequest , HttpResponse
7
8
from django .test import RequestFactory , override_settings
@@ -201,11 +202,8 @@ def test_get_response_multiple_regions(self):
201
202
202
203
with patch .object (parser , "get_integration_from_request" ) as method :
203
204
method .return_value = integration
204
- response = parser .get_response ()
205
+ # assert ValueError is raised if the integration is not valid
206
+ with pytest .raises (ValueError ):
207
+ parser .get_response ()
205
208
206
- # Response should go to first region
207
- assert isinstance (response , HttpResponse )
208
- assert response .status_code == status .HTTP_200_OK
209
- assert response .content == b"region response"
210
- assert len (responses .calls ) == 1
211
209
assert_no_webhook_payloads ()
You can’t perform that action at this time.
0 commit comments