Skip to content

Commit e8eff68

Browse files
authored
🔧 chore: remove extra jira logs (#93192)
1 parent 37eb6cc commit e8eff68

File tree

2 files changed

+6
-14
lines changed
  • src/sentry/middleware/integrations/parsers
  • tests/sentry/middleware/integrations/parsers

2 files changed

+6
-14
lines changed

src/sentry/middleware/integrations/parsers/jira.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,11 @@ def get_response(self):
6161
regions = self.get_regions_from_organizations()
6262

6363
if len(regions) == 0:
64-
logger.info("%s.no_regions", self.provider, extra={"path": self.request.path})
6564
return self.get_default_missing_integration_response()
6665

6766
if len(regions) > 1:
68-
# Since Jira is region_restricted (see JiraIntegrationProvider) we can just pick the
69-
# first region to forward along to.
70-
logger.info(
71-
"%s.too_many_regions",
72-
self.provider,
73-
extra={"path": self.request.path, "regions": regions},
74-
)
67+
# This shouldn't happen because we block multi region install at the install time.
68+
raise ValueError("Jira integration is installed in multiple regions")
7569

7670
if self.view_class in self.immediate_response_region_classes:
7771
try:

tests/sentry/middleware/integrations/parsers/test_jira.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from unittest.mock import patch
44

5+
import pytest
56
import responses
67
from django.http import HttpRequest, HttpResponse
78
from django.test import RequestFactory, override_settings
@@ -201,11 +202,8 @@ def test_get_response_multiple_regions(self):
201202

202203
with patch.object(parser, "get_integration_from_request") as method:
203204
method.return_value = integration
204-
response = parser.get_response()
205+
# assert ValueError is raised if the integration is not valid
206+
with pytest.raises(ValueError):
207+
parser.get_response()
205208

206-
# Response should go to first region
207-
assert isinstance(response, HttpResponse)
208-
assert response.status_code == status.HTTP_200_OK
209-
assert response.content == b"region response"
210-
assert len(responses.calls) == 1
211209
assert_no_webhook_payloads()

0 commit comments

Comments
 (0)