Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Replay: beforeXyz options #86905

Open
kahest opened this issue Mar 12, 2025 · 6 comments
Open

Mobile Replay: beforeXyz options #86905

kahest opened this issue Mar 12, 2025 · 6 comments

Comments

@kahest
Copy link
Member

kahest commented Mar 12, 2025

This issue is to discuss/track, which beforeXyz options we want to add to Mobile SDKs for Session Replay (if any).

Background

We currently provide a few beforeXyz options that users can use to adapt specific behaviours. From the docs:

  • beforeAddRecordingEvent: Filter additional recording events that include console logs and network requests/responses.
  • beforeErrorSampling: Filter error events which should be skipped for error sampling. Return false if error sampling should be skipped for this error event, or true to sample for this error. Will only be called in buffer mode.

For Mobile, we identified a few options we think might be valuable to add to support more varied use cases. Note that none of these are implemented and no alignment on naming, signature, etc. has happened until now:

@getsantry
Copy link
Contributor

getsantry bot commented Mar 12, 2025

Routing to @getsentry/product-owners-replays for triage ⏲️

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile SDKs Mar 12, 2025
@philprime
Copy link

I believe this one also relates to the topic by introducing a hook to get the encoded video segment, like onEncodedVideoSegment or similar.

getsentry/sentry-cocoa#4835

@bruno-garcia
Copy link
Member

beforeSendSessionReplay

Not sure how this one would work? We tried to offer this through beforeAddRecordingEvent. But "the replay" is made of segments. So we need to be sure we're not giving the wrong impression here that you can "drop" the replay once it has started/

@romtsn
Copy link
Member

romtsn commented Mar 13, 2025

beforeSendSessionReplay

Not sure how this one would work? We tried to offer this through beforeAddRecordingEvent. But "the replay" is made of segments. So we need to be sure we're not giving the wrong impression here that you can "drop" the replay once it has started/

I guess we'd have to educate that you'd need to hold onto replay_id and drop all events for the same one if you wanna drop a replay entirely.

@cobyeastwood183
Copy link

@cruddell001
Copy link

Our team is interested in the beforeSessionReplay event for mobile. Specifically, we want to limit the types of exceptions that qualify for session replays, and this seems like the most likely roadmap item to accomplish that. We are holding off using session replays until we can have such functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Needs Discussion
Development

No branches or pull requests

6 participants