ref(slack): Compact Slack issue alert message layout #105994
Merged
+270
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
leeandher
force-pushed
the
leander/eco-1315-improve-slack-issue-alert-message
branch
from
17702fa to
5f79552
Compare
leeandher
commented
Jan 9, 2026
Member
Author
There was a problem hiding this comment.
This test is very fragile, but would be a much bigger initiative to change for now, so I just resolved the indices. We were rendering the action_text block ('issue resolved by X') before the context on tags/counts -- when in reality it should be replacing the action block which is underneath it.
That correction, caused this rewrite :/
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Add tests for the slack-compact-alerts feature flag behavior: - Verify AI summary displays as "Initial Guess:" context block - Verify suggested assignees appear in compact format Also fix nested quote syntax error in get_issue_summary_text(). Refs ECO-1315 Co-Authored-By: Claude <[email protected]>
Store the feature flag result in an instance variable at the start of build() instead of checking it 8 times throughout the method. Also add a basic test for the compact layout without AI summary dependencies. Refs ECO-1315 Co-Authored-By: Claude <[email protected]>
The compact alerts refactor moved the action_text block from before the context block to after it. Update test assertions to use the correct block indices (blocks[2] -> blocks[3] for action_text). Co-Authored-By: Claude <[email protected]>
Add validation to prevent appending an empty context block when both get_context() returns empty and there are no suggested assignees. This mirrors the guard logic in the non-compact code path and prevents potential Slack API validation errors. Co-Authored-By: Claude <[email protected]>
Extract compact/non-compact block building logic into separate helper methods for better maintainability and testability. Add MAX_SUGGESTED_ASSIGNEES constant to limit displayed assignees to 3 in Slack messages. Addresses PR review feedback: - Truncate suggested assignees list to prevent overly long messages - Split compact mode logic into _build_context_blocks and _build_trailing_blocks Co-Authored-By: Claude <[email protected]>
Rename method to follow the build_ prefix convention used by other block-building methods in the class. Move method near related build_description_block and build_pre_footer_context_block methods. Co-Authored-By: Claude <[email protected]>
leeandher
force-pushed
the
leander/eco-1315-improve-slack-issue-alert-message
branch
from
1a34698 to
2861669
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Fix build_description_block to pass the stripped text variable instead of the original description_text, ensuring consistent whitespace handling. Strip context_text in build_group_context_block before empty check to prevent whitespace-only context blocks from being rendered. Co-Authored-By: Claude <[email protected]>
Rename method to plural form and return a list of blocks instead of a single optional block. This allows the method to return multiple context blocks (e.g., both suggested assignees and suspect commit) in the non-compact mode. Co-Authored-By: Claude <[email protected]>
GabeVillalobos
approved these changes
Jan 16, 2026
leeandher
deleted the
leander/eco-1315-improve-slack-issue-alert-message
branch
BYK
pushed a commit
that referenced
this pull request
Jan 19, 2026
Adds a slack-compact-alerts flag for the new alert layout. The compact layout won't affect most customers, key differences are - the AI summary is moved - title will not vary by your access to Seer - suggested assignee is moved to the context stats - suspect commit removed <img width="652" height="454" alt="image" src="https://github.com/user-attachments/assets/24ea61b5-3f76-4555-a9fd-7ab49ca6bb43" /> Hard to display all the differences without setting them up each feature and preventing race conditions (i.e. alert fires before suggested assignee is determined), so we can verify with tests and in production via the flag. --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a slack-compact-alerts flag for the new alert layout. The compact layout won't affect most customers, key differences are
Hard to display all the differences without setting them up each feature and preventing race conditions (i.e. alert fires before suggested assignee is determined), so we can verify with tests and in production via the flag.