Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to not emit decrypted file values into logs on 'complex value in dotenv file' failure #1198

Open
mistakenot opened this issue Apr 14, 2023 · 0 comments

Comments

@mistakenot
Copy link

If you try to run exec-env with a file with a complex value YAML entry, it fails and outputs the failing complex value block into the log. I wanted to raise this as a potential security risk, as it can lead to secrets being written into logs if this command fails in CI, for example.

I think this is the line where the error is generated:

https://github.com/mozilla/sops/blob/66043e71a81787d6513bc2e5505a29aac67dc6f1/stores/dotenv/store.go#L116

I would be very happy to submit a PR to change this, but wanted to raise it first to get your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant