macOS: Ctrl+L with Ergo-L keyboard layout doesn't produce a ctrl encoding

[mitchellh]

Steps to reproduce:

1. Install Ergo-L: https://ergol.org
2. Launch Ghostty
3. Run any keyboard input tracker, i.e. kitty +kitten show_key -m kitty (or any other)
4. Switch to Ergo-L
5. Ctrl+L (On US physical: Ctrl+H)

Notice the control key doesn't show up.

I've tracked this down to the code below, but this code exists for a reason. We should investigate why we do this, fix this, and ensure we don't regress the reason we did this in the first place.

ghostty/macos/Sources/Ghostty/SurfaceView_AppKit.swift

Lines 853 to 858 in c5508e7

	// This is a hack. libghostty on macOS treats ctrl input as not having
	// text because some keyboard layouts generate bogus characters for
	// ctrl+key. libghostty can't tell this is from an IM keyboard giving
	// us direct values. So, we just remove control.
	var modifierFlags = event.modifierFlags
	modifierFlags.remove(.control)

[guidoschmidt]

The line you mention above (modifierFlags.remove(.control)) actually also removes all kind of Ctrl + key combinations for me, e.g. writing zig b and use Ctrl + e to accept the auto completion to zig build. Or using Ctrl + w to remove the previous word.

Commenting out that line and doing a fresh build solved that for me, so seems to be not only related to Ergo-L. But as you mentioned, probably the removal of Ctrl had some purpose?

Though I'm actually using a Capslock key mapped onto Tab, you can set that up in macOS System Settings via Customise modifier keys.

[aurelberra]

Hello! I am using Ergo-L on macOS and I can confirm that I have lost all the usual Ctrl shortcuts in Ghostty with the latest update: Ctrl+a, Ctrl+e, Ctrl+c, etc.