macOS: toggle_visibility should do nothing with native fullscreen

[mitchellh]

Discussion: #5409

Steps to reproduce:

1. keybind = f=toggle_visibility
2. Launch Ghostty 1.1.0
3. Cmd+Enter to fullscreen (native)
4. Press f
5. Ghostty loses focus but otherwise nothing really happens

Expected: Ghostty should do nothing. Hidding an app (Cmd+H system) does nothing for other native apps like Terminal.app or TextEdit while fullscreen. Ghostty should behave the same here.

For the solution, we need to ensure we update the docs to note this too.

[shaps80]

Thanks for creating this! I'll take a look this weekend and submit a PR 👍
If its ok, I'll re-test the other issue and include that in the same PR (assuming the latest builds still have the issue).

[shaps80]

Ok I updated to 1.1.0 (facda0c) and I agree I can no longer reproduce the first issue so that's great 👏

As for the second issue, the app no longer seems to disappear/hide, in fact if its fullscreen (not split) it just switches back to the main space, hitting the key binding again, then switches back to the space correctly.

If its in a split, it seems to switch back and forth, between Ghostty and the other app in the split (with the keybinding).

So basically the only fix required is to ignore the keybinding in fullscreen mode. I'll do the fix and make a PR this weekend 👌

[shaps80]

@mitchellh I have a fix, its essentially one-liner, however you mentioned updating the docs. Where/how is this setup currently, I'm unable to find them in the repo but I'm probably just blind sorry.

If you're referring to the header docs in the code itself, I have indeed updated that, but just wanted to check in case you meant external markdown docs or similar?

I've opened #5472 for this issue 👌

[mitchellh]

Resolved with #5472