Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wrangling section on project info page. #3

Closed
cjvillar opened this issue Oct 3, 2019 · 4 comments
Closed

Update to wrangling section on project info page. #3

cjvillar opened this issue Oct 3, 2019 · 4 comments

Comments

@cjvillar
Copy link

cjvillar commented Oct 3, 2019

We propose the following changes to the wrangling section on the project info page.

Page:project info

  1. Capitalize “W” in the title of this section (aesthetics)

  2. Update terminology in the "wrangling status" Change starting to "status"

  3. Change "Effort" to "Project Source" This field need source enums, for example, pre-publication, GEO, ENA.

  4. Remove the following fields: “contacts”, “files”

  5. first/last contact dates is not helpful. A most recent contact date seems to be the best solution.

  6. Move “responders” up, and only keep First and last respond dates

@pnejad
Copy link

pnejad commented Oct 7, 2019

  1. Update terminology in the "wrangling status" Change starting to ""

@cjvillar what did you mean by this?

@JimKent
Copy link
Contributor

JimKent commented Oct 7, 2019

Looks good overall. On #4, I cut respondents already which I think addressed the contact part. The files part is sounds like it would be more useful to have URL of a brokering drive instead.

@JimKent
Copy link
Contributor

JimKent commented Oct 8, 2019

#1 is done, with the first letter of all sections including "Wrangling" now capitalized.
#2 What do you want changed? "status" as a status makes no sense. Do you want something else instead of "starting" for the initial one?
#3 Renamed the field "Effort" to "Project Source". The values here are controlled by the "x Project Source Type" table which currently can only be edited by Clay and me. We'll add an ENA (or other Euro) import if EBI agrees to do it, and we'll use their terms. Perhaps they will want to import from the Expression Atlas as well as ENA, I don't know.
#4 - Files is gone. In it's place is a slot for the URL to the wrangler drive. While I was tinkering I moved the git ticket url to be inside the wrangling section next to the wrangler drive. To me at least this makes sense, but perhaps other people than wranglers chat?
#5 - Could you just reframe "last contact" in your mind to not necessarily mean "final contact." I prefer to keep it as "last" because it is shorter, and it avoids changes to code and database.
#6 - Ended up keeping contacts and ditching responders since we didn't need both and contacts is more familiar.

@JimKent
Copy link
Contributor

JimKent commented Oct 8, 2019

ps - changes are currently just on the developers branch. I'll bundle them together with some changes from other tickets and likely update the production instance later today.

@JimKent JimKent closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants