Make spec and api checks clearer

mproffitt · mproffitt · commit 43dbed1c4735 · 2024-07-23T17:53:58.000+02:00
diff --git a/pkg/crd/crd.go b/pkg/crd/crd.go
@@ -74,11 +74,13 @@ func ParsePromise(iface any, crd *apiextensionsv1.CustomResourceDefinition) (err
 		crdYAMLBytes []byte
 	)
 
-	if spec, ok = iface.(map[string]any)["spec"].(map[string]any); !ok {
+	spec, ok = iface.(map[string]any)["spec"].(map[string]any)
+	if !ok {
 		return microerror.Maskf(CouldNotParseCRDFileError, "kratix promise is missing its spec")
 	}
 
-	if api, ok = spec["api"].(map[string]any); !ok {
+	api, ok = spec["api"].(map[string]any)
+	if !ok {
 		return microerror.Maskf(CouldNotParseCRDFileError, "kratix promise is missing its spec.api")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,13 @@ func ParsePromise(iface any, crd *apiextensionsv1.CustomResourceDefinition) (err`
`74`	`74`	`crdYAMLBytes []byte`
`75`	`75`	`)`
`76`	`76`
`77`		`- if spec, ok = iface.(map[string]any)["spec"].(map[string]any); !ok {`
	`77`	`+ spec, ok = iface.(map[string]any)["spec"].(map[string]any)`
	`78`	`+ if !ok {`
`78`	`79`	`return microerror.Maskf(CouldNotParseCRDFileError, "kratix promise is missing its spec")`
`79`	`80`	`}`
`80`	`81`
`81`		`- if api, ok = spec["api"].(map[string]any); !ok {`
	`82`	`+ api, ok = spec["api"].(map[string]any)`
	`83`	`+ if !ok {`
`82`	`84`	`return microerror.Maskf(CouldNotParseCRDFileError, "kratix promise is missing its spec.api")`
`83`	`85`	`}`
`84`	`86`