From 0eba33b13f045b7790bc9406bdb024ebae264565 Mon Sep 17 00:00:00 2001 From: David Manthey Date: Fri, 21 Apr 2023 12:29:25 -0400 Subject: [PATCH] Allow clearing the min/max fields of the frame selector. --- CHANGELOG.md | 5 +++++ .../web_client/vue/components/CompositeLayers.vue | 5 ++--- .../web_client/vue/components/FrameSelector.vue | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 879e8599c..6ff74be4d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Change Log +## 1.20.6 + +### Bug Fixes +- Allow clearing the min/max fields of the frame selector ([#1030](../../pull/1030)) + ## 1.20.5 ### Improvements diff --git a/girder/girder_large_image/web_client/vue/components/CompositeLayers.vue b/girder/girder_large_image/web_client/vue/components/CompositeLayers.vue index 3024c5a55..6ae251185 100644 --- a/girder/girder_large_image/web_client/vue/components/CompositeLayers.vue +++ b/girder/girder_large_image/web_client/vue/components/CompositeLayers.vue @@ -89,13 +89,13 @@ export default { }, updateLayerMin(event, layer) { const newVal = event.target.value; - const newMinVal = parseFloat(newVal); + const newMinVal = Number.isFinite(newVal) ? parseFloat(newVal) : undefined; this.compositeLayerInfo[layer].min = newMinVal; this.updateStyle(); }, updateLayerMax(event, layer) { const newVal = event.target.valueAsNumber; - const newMaxVal = parseFloat(newVal); + const newMaxVal = Number.isFinite(newVal) ? parseFloat(newVal) : undefined; this.compositeLayerInfo[layer].max = newMaxVal; this.updateStyle(); }, @@ -192,7 +192,6 @@ export default { @change.prevent="(event) => updateLayerMax(event, layer)" > - diff --git a/girder/girder_large_image/web_client/vue/components/FrameSelector.vue b/girder/girder_large_image/web_client/vue/components/FrameSelector.vue index 466769c32..6bc449076 100644 --- a/girder/girder_large_image/web_client/vue/components/FrameSelector.vue +++ b/girder/girder_large_image/web_client/vue/components/FrameSelector.vue @@ -120,7 +120,7 @@ export default Vue.extend({ ) } this.sliderModes.push( - { id: 3, name: 'Advanced Band Compositing' } + { id: 3, name: 'Band Compositing' } ) } },