Skip to content

Commit 30115ee

Browse files
committed
fix contexts
1 parent 070eb9f commit 30115ee

File tree

22 files changed

+67
-63
lines changed

22 files changed

+67
-63
lines changed

controllers/backup/configmap.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func (r *RepoManagerBackupReconciler) createConfigMapBackupFile(ctx context.Cont
7979
execCmd := []string{
8080
"bash", "-c", fmt.Sprintf("cat<<EOF> %s/%s \n%sEOF", configMapType.backupDir, configMapType.backupFile, configMapYaml.String()),
8181
}
82-
_, err = controllers.ContainerExec(r, configMapType.pod, execCmd, configMapType.pulpBackup.Name+"-backup-manager", configMapType.pod.Namespace)
82+
_, err = controllers.ContainerExec(ctx, r, configMapType.pod, execCmd, configMapType.pulpBackup.Name+"-backup-manager", configMapType.pod.Namespace)
8383
if err != nil {
8484
log.Error(err, "Failed to backup "+configMapType.configMapName+" configmap")
8585
return err

controllers/backup/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ func (r *RepoManagerBackupReconciler) Reconcile(ctx context.Context, req ctrl.Re
9696
return ctrl.Result{}, err
9797
}
9898

99-
if err = r.createBackupDir(pulpBackup, backupDir, pod); err != nil {
99+
if err = r.createBackupDir(ctx, pulpBackup, backupDir, pod); err != nil {
100100
r.updateStatus(ctx, pulpBackup, metav1.ConditionFalse, "BackupComplete", "Failed to create backup directory!", "FailedCreateBkpDir")
101101
return ctrl.Result{}, err
102102
}

controllers/backup/cr.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func (r *RepoManagerBackupReconciler) backupCR(ctx context.Context, pulpBackup *
3030
execCmd := []string{
3131
"bash", "-c", "echo '" + string(pulpSpec) + "' > " + backupDir + "/cr_object",
3232
}
33-
_, err = controllers.ContainerExec(r, pod, execCmd, pulpBackup.Name+"-backup-manager", pod.Namespace)
33+
_, err = controllers.ContainerExec(ctx, r, pod, execCmd, pulpBackup.Name+"-backup-manager", pod.Namespace)
3434
if err != nil {
3535
log.Error(err, "Failed to backup Pulp CR")
3636
return err

controllers/backup/database.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ func (r *RepoManagerBackupReconciler) backupDatabase(ctx context.Context, pulpBa
1818

1919
log.Info("Starting database backup process ...")
2020
execCmd := []string{"touch", backupDir + "/" + backupFile}
21-
_, err := controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
21+
_, err := controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
2222
if err != nil {
2323
log.Error(err, "Failed to create pulp.db backup file")
2424
return err
2525
}
2626

2727
execCmd = []string{"chmod", "0600", backupDir + "/" + backupFile}
28-
_, err = controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
28+
_, err = controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
2929
if err != nil {
3030
log.Error(err, "Failed to modify backup file permissions")
3131
return err
@@ -43,7 +43,7 @@ func (r *RepoManagerBackupReconciler) backupDatabase(ctx context.Context, pulpBa
4343
"-f", backupDir + "/" + backupFile,
4444
}
4545

46-
_, err = controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
46+
_, err = controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
4747
if err != nil {
4848
log.Error(err, "Failed to run pg_dump")
4949
return err

controllers/backup/pulp_dir.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func (r *RepoManagerBackupReconciler) backupPulpDir(ctx context.Context, pulpBac
2626
execCmd := []string{
2727
"mkdir", "-p", backupDir + "/pulp",
2828
}
29-
_, err := controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
29+
_, err := controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
3030
if err != nil {
3131
log.Error(err, "Failed to create pulp backup dir")
3232
return err
@@ -35,7 +35,7 @@ func (r *RepoManagerBackupReconciler) backupPulpDir(ctx context.Context, pulpBac
3535
execCmd = []string{
3636
"bash", "-c", "cp -fa /var/lib/pulp/. " + backupDir + "/pulp",
3737
}
38-
_, err = controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
38+
_, err = controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
3939
if err != nil {
4040
log.Error(err, "Failed to backup pulp dir")
4141
return err

controllers/backup/secret.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func (r *RepoManagerBackupReconciler) createBackupFile(ctx context.Context, secr
162162
execCmd := []string{
163163
"bash", "-c", "echo '" + string(secretSerialized) + "' > " + secretType.backupDir + "/" + secretType.backupFile,
164164
}
165-
_, err = controllers.ContainerExec(r, secretType.pod, execCmd, secretType.pulpBackup.Name+"-backup-manager", secretType.pod.Namespace)
165+
_, err = controllers.ContainerExec(ctx, r, secretType.pod, execCmd, secretType.pulpBackup.Name+"-backup-manager", secretType.pod.Namespace)
166166
if err != nil {
167167
log.Error(err, "Failed to backup "+secretType.secretName+" secret")
168168
return err
@@ -191,7 +191,7 @@ func (r *RepoManagerBackupReconciler) createSecretBackupFile(ctx context.Context
191191
execCmd := []string{
192192
"bash", "-c", "echo '" + secretYaml.String() + "' > " + secretType.backupDir + "/" + secretType.backupFile,
193193
}
194-
_, err = controllers.ContainerExec(r, secretType.pod, execCmd, secretType.pulpBackup.Name+"-backup-manager", secretType.pod.Namespace)
194+
_, err = controllers.ContainerExec(ctx, r, secretType.pod, execCmd, secretType.pulpBackup.Name+"-backup-manager", secretType.pod.Namespace)
195195
if err != nil {
196196
log.Error(err, "Failed to backup "+secretType.secretName+" secret")
197197
return err

controllers/backup/utils.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ import (
1010
)
1111

1212
// createBackupDir creates the directory to store the backup
13-
func (r *RepoManagerBackupReconciler) createBackupDir(pulpBackup *pulpv1.PulpBackup, backupDir string, pod *corev1.Pod) error {
13+
func (r *RepoManagerBackupReconciler) createBackupDir(ctx context.Context, pulpBackup *pulpv1.PulpBackup, backupDir string, pod *corev1.Pod) error {
1414
log := r.RawLogger
1515
backupPod := pulpBackup.Name + "-backup-manager"
1616

1717
log.Info("Creating backup folder ...")
1818
execCmd := []string{"mkdir", "-p", backupDir}
19-
_, err := controllers.ContainerExec(r, pod, execCmd, backupPod, pod.Namespace)
19+
_, err := controllers.ContainerExec(ctx, r, pod, execCmd, backupPod, pod.Namespace)
2020
if err != nil {
2121
log.Error(err, "Failed to create backup folder")
2222
return err

controllers/deployment.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ func (d *CommonDeployment) setTopologySpreadConstraints(pulp pulpv1.Pulp, pulpco
226226
func (d *CommonDeployment) setEnvVars(resources any, pulpcoreType settings.PulpcoreType) {
227227
pulp := resources.(FunctionResources).Pulp
228228
pulpcoreTypeField := reflect.ValueOf(pulp.Spec).FieldByName(string(pulpcoreType))
229+
ctx := resources.(FunctionResources).Context
229230

230231
envVars := SetPulpcoreCustomEnvVars(*pulp, pulpcoreType)
231232

@@ -323,7 +324,7 @@ func (d *CommonDeployment) setEnvVars(resources any, pulpcoreType settings.Pulpc
323324
if pulp.Spec.SigningSecret != "" {
324325

325326
// for now, we are just dumping the error, but we should handle it
326-
signingKeyFingerprint, _ := GetSigningKeyFingerprint(resources.(FunctionResources).Client, pulp.Spec.SigningSecret, pulp.Namespace)
327+
signingKeyFingerprint, _ := GetSigningKeyFingerprint(ctx, resources.(FunctionResources).Client, pulp.Spec.SigningSecret, pulp.Namespace)
327328

328329
signingKeyEnvVars := []corev1.EnvVar{
329330
{Name: "PULP_SIGNING_KEY_FINGERPRINT", Value: signingKeyFingerprint},
@@ -744,6 +745,7 @@ func (d *CommonDeployment) setInitContainerResourceRequirements(pulp pulpv1.Pulp
744745
// setReadinessProbe defines the container readinessprobe
745746
func (d *CommonDeployment) setReadinessProbe(resources any, pulp pulpv1.Pulp, pulpcoreType settings.PulpcoreType) {
746747
readinessProbe := reflect.ValueOf(pulp.Spec).FieldByName(string(pulpcoreType)).FieldByName("ReadinessProbe").Interface().(*corev1.Probe)
748+
ctx := resources.(FunctionResources).Context
747749
switch pulpcoreType {
748750
case settings.API:
749751
if readinessProbe == nil {
@@ -752,7 +754,7 @@ func (d *CommonDeployment) setReadinessProbe(resources any, pulp pulpv1.Pulp, pu
752754
Exec: &corev1.ExecAction{
753755
Command: []string{
754756
"/usr/bin/readyz.py",
755-
GetAPIRoot(resources.(FunctionResources).Client, &pulp) + "api/v3/status/",
757+
GetAPIRoot(ctx, resources.(FunctionResources).Client, &pulp) + "api/v3/status/",
756758
},
757759
},
758760
},
@@ -770,7 +772,7 @@ func (d *CommonDeployment) setReadinessProbe(resources any, pulp pulpv1.Pulp, pu
770772
Exec: &corev1.ExecAction{
771773
Command: []string{
772774
"/usr/bin/readyz.py",
773-
GetContentPathPrefix(resources.(FunctionResources).Client, &pulp),
775+
GetContentPathPrefix(ctx, resources.(FunctionResources).Client, &pulp),
774776
},
775777
},
776778
},
@@ -806,14 +808,15 @@ func (d *CommonDeployment) setReadinessProbe(resources any, pulp pulpv1.Pulp, pu
806808
// setReadinessProbe defines the container livenessprobe
807809
func (d *CommonDeployment) setLivenessProbe(resources any, pulp pulpv1.Pulp, pulpcoreType settings.PulpcoreType) {
808810
livenessProbe := reflect.ValueOf(pulp.Spec).FieldByName(string(pulpcoreType)).FieldByName("LivenessProbe").Interface().(*corev1.Probe)
811+
ctx := resources.(FunctionResources).Context
809812
switch pulpcoreType {
810813
case settings.API:
811814
if livenessProbe == nil {
812815
livenessProbe = &corev1.Probe{
813816
FailureThreshold: 10,
814817
ProbeHandler: corev1.ProbeHandler{
815818
HTTPGet: &corev1.HTTPGetAction{
816-
Path: GetAPIRoot(resources.(FunctionResources).Client, &pulp) + "api/v3/status/",
819+
Path: GetAPIRoot(ctx, resources.(FunctionResources).Client, &pulp) + "api/v3/status/",
817820
Port: intstr.IntOrString{
818821
IntVal: 24817,
819822
},
@@ -887,6 +890,7 @@ func (d *CommonDeployment) setInitContainers(resources any, pulp pulpv1.Pulp, pu
887890

888891
// setGpgInitContainer returns the definition of a container used to store the gpg keys in the keyring
889892
func setGpgInitContainer(resources any, pulp pulpv1.Pulp) corev1.Container {
893+
ctx := resources.(FunctionResources).Context
890894
volumeMounts := []corev1.VolumeMount{
891895
{
892896
Name: "gpg-keys",
@@ -922,7 +926,7 @@ func setGpgInitContainer(resources any, pulp pulpv1.Pulp) corev1.Container {
922926
},
923927
}
924928

925-
signingKeyFingerprint, _ := GetSigningKeyFingerprint(resources.(FunctionResources).Client, pulp.Spec.SigningSecret, pulp.Namespace)
929+
signingKeyFingerprint, _ := GetSigningKeyFingerprint(ctx, resources.(FunctionResources).Client, pulp.Spec.SigningSecret, pulp.Namespace)
926930

927931
// env vars
928932
envVars := []corev1.EnvVar{{Name: "PULP_SIGNING_KEY_FINGERPRINT", Value: signingKeyFingerprint}}

controllers/ocp/route.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func PulpRouteController(resources controllers.FunctionResources, restClient res
100100
execCmd := []string{
101101
"/usr/bin/route_paths.py", pulp.Name,
102102
}
103-
cmdOutput, err := controllers.ContainerExec(PodExec{restClient, restConfig, resources.Scheme}, &pod, execCmd, "worker", pod.Namespace)
103+
cmdOutput, err := controllers.ContainerExec(ctx, PodExec{restClient, restConfig, resources.Scheme}, &pod, execCmd, "worker", pod.Namespace)
104104
if err != nil {
105105
controllers.CustomZapLogger().Warn(err.Error() + " Failed to get routes from " + pod.Name)
106106
controllers.UpdateStatus(ctx, resources.Client, pulp, metav1.ConditionFalse, conditionType, "Failed to get routes!", "FailedGet"+pod.Name)
@@ -111,13 +111,13 @@ func PulpRouteController(resources controllers.FunctionResources, restClient res
111111
defaultPlugins := []RoutePlugin{
112112
{
113113
Name: pulp.Name + "-content",
114-
Path: controllers.GetContentPathPrefix(resources.Client, pulp),
114+
Path: controllers.GetContentPathPrefix(ctx, resources.Client, pulp),
115115
TargetPort: "content-24816",
116116
ServiceName: settings.ContentService(pulp.Name),
117117
},
118118
{
119119
Name: pulp.Name + "-api-v3",
120-
Path: controllers.GetAPIRoot(resources.Client, pulp) + "api/v3/",
120+
Path: controllers.GetAPIRoot(ctx, resources.Client, pulp) + "api/v3/",
121121
TargetPort: "api-24817",
122122
ServiceName: settings.ApiService(pulp.Name),
123123
},

controllers/repo_manager/ingress.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func (r *RepoManagerReconciler) pulpIngressController(ctx context.Context, pulp
7373
execCmd := []string{
7474
"/usr/bin/route_paths.py", pulp.Name,
7575
}
76-
cmdOutput, err := controllers.ContainerExec(r, &pod, execCmd, "content", pod.Namespace)
76+
cmdOutput, err := controllers.ContainerExec(ctx, r, &pod, execCmd, "content", pod.Namespace)
7777
if err != nil {
7878
controllers.CustomZapLogger().Warn(err.Error() + " Failed to get ingresss from " + pod.Name)
7979
controllers.UpdateStatus(ctx, r.Client, pulp, metav1.ConditionFalse, conditionType, "Failed to get ingresss!", "FailedGet"+pod.Name)
@@ -84,13 +84,13 @@ func (r *RepoManagerReconciler) pulpIngressController(ctx context.Context, pulp
8484
defaultPlugins := []controllers.IngressPlugin{
8585
{
8686
Name: pulp.Name + "-content",
87-
Path: controllers.GetContentPathPrefix(r.Client, pulp),
87+
Path: controllers.GetContentPathPrefix(ctx, r.Client, pulp),
8888
TargetPort: "content-24816",
8989
ServiceName: settings.ContentService(pulp.Name),
9090
},
9191
{
9292
Name: pulp.Name + "-api-v3",
93-
Path: controllers.GetAPIRoot(r.Client, pulp) + "api/v3/",
93+
Path: controllers.GetAPIRoot(ctx, r.Client, pulp) + "api/v3/",
9494
TargetPort: "api-24817",
9595
ServiceName: settings.ApiService(pulp.Name),
9696
},

0 commit comments

Comments
 (0)