Merge pull request #1955 from dscho/verify-search-results-in-playwright

Verify the search results page in playwright

Author: dscho

.github/workflows/playwright.yml

@@ -6,10 +6,6 @@ on:
         description: 'URL to test'
         required: true
         default: 'https://git-scm.com'
-      assume-rails-app:
-        description: 'Whether the URL points to the original Rails app variant of the site'
-        required: false
-        default: 'false'
 jobs:
   test:
     timeout-minutes: 60
@@ -24,7 +20,6 @@ jobs:
     - name: Run Playwright tests
       env:
         PLAYWRIGHT_TEST_URL: ${{ github.event.inputs.url }}
-        PLAYWRIGHT_ASSUME_RAILS_APP: ${{ github.event.inputs.assume-rails-app }}
       run: npx playwright test --project=chrome
     - uses: actions/upload-artifact@v4
       if: always()

tests/git-scm.spec.js

@@ -3,7 +3,6 @@ const { test, expect, selectors, devices } = require('@playwright/test')
 const url = process.env.PLAYWRIGHT_TEST_URL
   ? process.env.PLAYWRIGHT_TEST_URL.replace(/[^/]$/, '$&/')
   : 'https://git-scm.com/'
-const isRailsApp = process.env.PLAYWRIGHT_ASSUME_RAILS_APP === 'true'
 
 // Whenever a test fails, attach a screenshot to diagnose failures better
 test.afterEach(async ({ page }, testInfo) => {
@@ -24,11 +23,7 @@ test.afterEach(async ({ page }, testInfo) => {
 
 test('generator is Hugo', async ({page}) => {
   await page.goto(url)
-  if (isRailsApp) {
-    await expect(page.locator('meta[name="generator"]')).toHaveCount(0)
-  } else {
-    await expect(page.locator('meta[name="generator"]')).toHaveAttribute('content', /^Hugo /)
-  }
+  await expect(page.locator('meta[name="generator"]')).toHaveAttribute('content', /^Hugo /)
 })
 
 async function pretendPlatform(page, browserName, userAgent, platform) {
@@ -122,23 +117,31 @@ test('search', async ({ page }) => {
   await expect(searchResults.getByRole("link")).not.toHaveCount(0)
   await expect(searchResults.getByRole("link").nth(0)).toHaveText('git-commit')
 
+  // Expect the search page to show up
+  await searchBox.press('Enter')
+  await expect(page).toHaveURL(/\/search/)
+  const filters = await page.getByRole('group', { name: 'Filters' })
+  await expect(filters).toBeVisible()
+  await expect(filters.filter({ hasText: 'Category' })).toBeVisible()
+
+  await expect(page.getByText(/results for commit/)).toContainText(/^\d+ results for commit$/)
+
+  const searchLinks = await page
+    .getByRole('listItem')
+    .filter({ has: page.getByRole('link', { name: 'commit' }) })
+  await expect(searchLinks).not.toHaveCount(0)
+
+  await expect(page.getByRole('button', { name: 'Load more results' })).toBeVisible()
+
   // On localized pages, the search results should be localized as well
   await page.goto(`${url}docs/git-commit/fr`)
   await searchBox.fill('add')
   await searchBox.press('Shift')
-  if (isRailsApp) {
-    await expect(searchResults.getByRole("link").nth(0)).toHaveAttribute('href', /\/docs\/git-add$/)
-  } else {
-    await expect(searchResults.getByRole("link").nth(0)).toHaveAttribute('href', /\/docs\/git-add\/fr(\.html)?$/)
-  }
+  await expect(searchResults.getByRole("link").nth(0)).toHaveAttribute('href', /\/docs\/git-add\/fr(\.html)?$/)
 
   // pressing the Enter key should navigate to the full search results page
   await searchBox.press('Enter')
-  if (isRailsApp) {
-    await expect(page).toHaveURL(/\/search/)
-  } else {
-    await expect(page).toHaveURL(/\/search.*language=fr/)
-  }
+  await expect(page).toHaveURL(/\/search.*language=fr/)
 })
 
 test('manual pages', async ({ page }) => {
@@ -152,11 +155,7 @@ test('manual pages', async ({ page }) => {
   // Verify that the drop-downs are shown when clicked
   const previousVersionDropdown = page.locator('#previous-versions-dropdown')
   await expect(previousVersionDropdown).toBeHidden()
-  if (isRailsApp) {
-    await page.getByRole('link', { name: /Version \d+\.\d+\.\d+/ }).click()
-  } else {
-    await page.getByRole('link', { name: 'Latest version' }).click()
-  }
+  await page.getByRole('link', { name: 'Latest version' }).click()
   await expect(previousVersionDropdown).toBeVisible()
 
   const topicsDropdown = page.locator('#topics-dropdown')
@@ -188,14 +187,8 @@ test('manual pages', async ({ page }) => {
   // Ensure that the French mis-translation of `git remote renom` is not present
   await page.goto(`${url}docs/git-remote/fr`)
   const synopsis = page.locator('xpath=//h2[contains(text(), "SYNOPSIS")]/following-sibling::*[1]').first()
-  if (isRailsApp) {
-    // This is a bug in the Rails app, and it is unclear what the root cause is
-    await expect(synopsis).not.toHaveText(/git remote rename.*<ancien> <nouveau>/)
-    await expect(synopsis).toHaveText(/git remote renom.*<ancien> <nouveau>/)
-  } else {
-    await expect(synopsis).toHaveText(/git remote rename.*<ancien> <nouveau>/)
-    await expect(synopsis).not.toHaveText(/git remote renom.*<ancien> <nouveau>/)
-  }
+  await expect(synopsis).toHaveText(/git remote rename.*<ancien> <nouveau>/)
+  await expect(synopsis).not.toHaveText(/git remote renom.*<ancien> <nouveau>/)
 })
 
 test('book', async ({ page }) => {
@@ -245,12 +238,7 @@ test('book', async ({ page }) => {
 
   // Navigate to a page whose URL contains a question mark
   await page.goto(`${url}book/az/v2/Başlanğıc-Git-Nədir?`)
-  if (isRailsApp) {
-    await expect(page).toHaveURL(/book\/az\/v2$/)
-    await page.goto(`${url}book/az/v2/Başlanğıc-Git-Nədir%3F`)
-  } else {
-    await expect(page).toHaveURL(/Ba%C5%9Flan%C4%9F%C4%B1c-Git-N%C9%99dir%3F/)
-  }
+  await expect(page).toHaveURL(/Ba%C5%9Flan%C4%9F%C4%B1c-Git-N%C9%99dir%3F/)
   await expect(page.getByRole('document')).toHaveText(/Snapshot’lar, Fərqlər Yox/)
 
   // the repository URL now points to the Azerbaijani translation