Skip to content

Commit 99e9f7e

Browse files
committed
amend! ci: upload Playwright tests' results even in PR builds
ci: upload Playwright tests' results even in PR builds We do that in all other workflows that run the Playwright tests, and it is very helpful when diagnosing issues (especially the screenshots that are stored on failure). This needs a slight change in the Playwright configuration where we now want to have the `github` reporter _in addition_ to the `html` reporter (and not instead of it). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 2c8bd70 commit 99e9f7e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

playwright.config.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ module.exports = defineConfig({
2222
workers: process.env.CI ? 1 : undefined,
2323
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
2424
/* Uses 'github' for GitHub Actions CI to generate annotations, otherwise 'html' */
25-
reporter: process.env.CI && process.env.PLAYWRIGHT_TEST_URL === 'http://localhost:5000/' ? 'github' : 'html',
25+
reporter: [
26+
[ 'html' ],
27+
...(process.env.CI && process.env.PLAYWRIGHT_TEST_URL === 'http://localhost:5000/' ? [ 'github' ] : [])
28+
],
2629
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
2730
use: {
2831
/* Base URL to use in actions like `await page.goto('/')`. */

0 commit comments

Comments
 (0)