Skip to content

Commit a29d864

Browse files
authored
Merge pull request #1902 from dscho/upgrade-lychee
Upgrade lychee
2 parents e857def + 72393de commit a29d864

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

.github/actions/deploy-to-github-pages/action.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,8 @@ runs:
122122
123123
- name: check for broken links
124124
id: lychee
125-
uses: lycheeverse/lychee-action@d4128702eae98bbc5ecf74df0165a8156c80920a # until an official version is out that includes https://github.com/lycheeverse/lychee/pull/1422
125+
uses: lycheeverse/lychee-action@v2
126126
with:
127-
lycheeVersion: nightly # until an official version includes https://github.com/lycheeverse/lychee/pull/1422
128127
args: >-
129128
--offline
130129
--fallback-extensions html
@@ -144,7 +143,8 @@ runs:
144143
fail: false
145144
failIfEmpty: false # needed because its default overrides `fail = false`
146145

147-
- name: ${{ env.lychee_exit_code != '0' && 'maybe close' || 'open or update' }} link checker issue
146+
- name: ${{ env.lychee_exit_code != '0' && 'open or update' || 'maybe close' }} link checker issue
147+
if: env.lychee_exit_code != ''
148148
uses: actions/github-script@v7
149149
with:
150150
github-token: ${{ inputs.github-token }}
@@ -198,6 +198,7 @@ runs:
198198
run: sudo sh -c 'echo "185.199.108.153 git-scm.com" >>/etc/hosts'
199199
- name: Run Playwright tests
200200
shell: bash
201+
id: playwright
201202
env:
202203
PLAYWRIGHT_TEST_URL: ${{ steps.pages.outputs.base_url }}
203204
run: |
@@ -206,9 +207,10 @@ runs:
206207
https://*|http://git-scm.com) ;; # okay, leave as-is
207208
http://*) PLAYWRIGHT_TEST_URL="https://${PLAYWRIGHT_TEST_URL#http://}";;
208209
esac &&
210+
echo "result=$PLAYWRIGHT_TEST_URL" >>$GITHUB_OUTPUT &&
209211
npx playwright test --project=chrome
210212
- uses: actions/upload-artifact@v4
211-
if: always()
213+
if: always() && steps.playwright.outputs.result != ''
212214
with:
213215
name: playwright-report
214216
path: playwright-report/

.github/workflows/ci.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,8 @@ jobs:
6060
6161
- name: check for broken links
6262
id: lychee
63-
uses: lycheeverse/lychee-action@d4128702eae98bbc5ecf74df0165a8156c80920a # until an official version is out that includes https://github.com/lycheeverse/lychee/pull/1422
63+
uses: lycheeverse/lychee-action@v2
6464
with:
65-
lycheeVersion: nightly # until an official version includes https://github.com/lycheeverse/lychee/pull/1422
6665
args: >-
6766
--offline
6867
--fallback-extensions html
@@ -80,11 +79,14 @@ jobs:
8079
- name: Install @playwright/test
8180
run: npm install @playwright/test
8281
- name: Run Playwright tests
82+
id: playwright
8383
env:
8484
PLAYWRIGHT_TEST_URL: http://localhost:5000/
85-
run: npx playwright test --project=chrome
85+
run: |
86+
echo "result=$PLAYWRIGHT_TEST_URL" >>$GITHUB_OUTPUT &&
87+
npx playwright test --project=chrome
8688
- uses: actions/upload-artifact@v4
87-
if: always()
89+
if: always() && steps.playwright.outputs.result != ''
8890
with:
8991
name: playwright-report
9092
path: playwright-report/

0 commit comments

Comments
 (0)