Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem using zoom in the page #1916

Closed
Fede5432 opened this issue Nov 12, 2024 · 2 comments · Fixed by #1917
Closed

Problem using zoom in the page #1916

Fede5432 opened this issue Nov 12, 2024 · 2 comments · Fixed by #1917

Comments

@Fede5432
Copy link

Fede5432 commented Nov 12, 2024 •
edited
Loading

When I have the 150% zoom in the page and I open up this hidden list which contains "about", "documentation", etc. When I select one of them I can't get in

image
@Fede5432 Fede5432 changed the title Problem with using zoom in the page Problem using zoom in the page Nov 12, 2024
dscho added a commit to dscho/git-scm.com that referenced this issue Nov 12, 2024
@dscho
Keep sidebar open when clicking inside it
7991fa4 
The "sidebar menu" is implemented via two <div>s, one acting as the
button (`.sidebar-btn`), the other as the menu (`.sidebar`).

The menu is shown by virtue of a `.sidebar-btn:focus + .sidebar` rule
that sets the `transform` attribute to 0 (it defaults to -105.5%).

The big problem with this design is that clicking inside the sidebar
menu transfers focus away from the button, and the sidebar menu
vanishes. Typically without following the link that the viewer clicked,
as reported in git#1916.

Let's let the sidebar menu be shown also when the focus is within said
menu, via the `:focus-within` pseudo-class (for more details, see
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-within), which
is supported reasonably widely by browsers.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this issue Nov 12, 2024
Merged
dscho added a commit to dscho/git-scm.com that referenced this issue Nov 12, 2024
@dscho
Merge branch 'fixsidebar-btn'
fb26f7f 
This fixes git#1916.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Nov 12, 2024

@Fede5432 thank you for reporting this issue! I have opened #1917 to fix this, and deployed it to https://dscho.github.io/git-scm.com/. Could you please verify that it works for you there?

@Fede5432
Copy link
Author

@Fede5432 thank you for reporting this issue! I have opened #1917 to fix this, and deployed it to https://dscho.github.io/git-scm.com/. Could you please verify that it works for you there?

It works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep sidebar open when clicking inside it dscho/git-scm.com
2 participants
@dscho @Fede5432