chore: address feedback from PR

Author: vacekj

.eslintrc.cjs

@@ -8,10 +8,11 @@ module.exports = {
     project: `./tsconfig.json`,
   },
   parser: "@typescript-eslint/parser",
-  plugins: ["@typescript-eslint"],
+  plugins: ["@typescript-eslint", "no-only-tests"],
   root: true,
   rules: {
     "no-unused-vars": "off",
+    "no-only-tests/no-only-tests": "error",
     "@typescript-eslint/no-misused-promises": [
       "error",
       {

package-lock.json

@@ -74,6 +74,7 @@
     "@typescript-eslint/parser": "^5.55.0",
     "concurrently": "^8.2.0",
     "eslint": "^8.36.0",
+    "eslint-plugin-no-only-tests": "^3.1.0",
     "lefthook": "^1.4.8",
     "prettier": "^3.0.1",
     "supertest": "^6.3.3",

package.json

@@ -296,7 +296,7 @@ export default class Calculator {
       `${this.chainId}/rounds.json`
     );
 
-    const round = rounds.find((r: Round) => r.id === this.roundId);
+    const round = rounds.find((round) => round.id === this.roundId);
 
     if (round === undefined) {
       throw new ResourceNotFoundError("round");

src/calculator/index.ts

@@ -124,16 +124,14 @@ export const createHandler = (config: HttpApiConfig): express.Router => {
   ) {
     const chainId = Number(req.params.chainId);
     const roundId = req.params.roundId;
-    const potentialVotes = potentialVotesSchema
-      .parse((req.body as { potentialVotes: PotentialVotes }).potentialVotes)
-      .map((vote) => ({
-        ...vote,
-        amount: BigInt(vote.amount),
-      }));
+    const potentialVotes = potentialVotesSchema.parse(req.body).map((vote) => ({
+      ...vote,
+      amount: vote.amount,
+    }));
 
     const chainConfig = config.chains.find((c) => c.id === chainId);
     if (chainConfig === undefined) {
-      throw new Error(`Chain ${chainId} not configured`);
+      throw new ClientError(`Chain ${chainId} not configured`, 400);
     }
 
     const calculatorOptions: CalculatorOptions = {

src/http/api/v1/matches.ts

@@ -168,7 +168,7 @@ async function catchupAndWatchChain(
     // Force a full re-indexing on every startup.
     // XXX For the longer term, verify whether ChainSauce supports
     // any sort of stop-and-resume.
-    await fs.rm(CHAIN_DIR_PATH, { force: true, recursive: true });
+    // await fs.rm(CHAIN_DIR_PATH, { force: true, recursive: true });
 
     const storage = new JsonStorage(CHAIN_DIR_PATH);
 

src/index.ts

@@ -326,7 +326,7 @@ describe("server", () => {
         expect(resp.body).toEqual(expectedResults);
       });
 
-      test.only("should estimate matching with new votes for projects", async () => {
+      test("should estimate matching with new votes for projects", async () => {
         const expectedResults = [
           {
             applicationId: "application-id-1",