Skip to content

Commit e24570b

Browse files
committed
Merge branch 'jk/check-mailmap-wo-name-fix'
"git check-mailmap" segfault fix. * jk/check-mailmap-wo-name-fix: mailmap: fix check-mailmap with full mailmap line
2 parents bbca240 + bb60c52 commit e24570b

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

builtin/check-mailmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ static void check_mailmap(struct string_list *mailmap, const char *contact)
3535
mail = ident.mail_begin;
3636
maillen = ident.mail_end - ident.mail_begin;
3737
} else {
38-
name = NULL;
38+
name = "";
3939
namelen = 0;
4040
mail = contact;
4141
maillen = strlen(contact);

t/t4203-mailmap.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,18 @@ test_expect_success 'check-mailmap --stdin simple address: no mapping' '
113113
test_cmp expect actual
114114
'
115115

116+
test_expect_success 'check-mailmap name and address: mapping' '
117+
test_when_finished "rm .mailmap" &&
118+
cat >.mailmap <<-EOF &&
119+
120+
EOF
121+
cat >expect <<-EOF &&
122+
123+
EOF
124+
git check-mailmap "[email protected]" >actual &&
125+
test_cmp expect actual
126+
'
127+
116128
test_expect_success 'No mailmap' '
117129
cat >expect <<-EOF &&
118130
$GIT_AUTHOR_NAME (1):

0 commit comments

Comments
 (0)