Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce linux kernel packet validity constraints #194

Open
daniel-noland opened this issue Jan 31, 2025 · 0 comments
Open

Enforce linux kernel packet validity constraints #194

daniel-noland opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement New feature or request meta

Comments

@daniel-noland
Copy link
Collaborator

Unsurprisingly, etherparse and the linux kernel do not have complete alignment regarding what constitutes a valid packet.

A simple example of this can be found in etherparse::Ipv4HeaderSlice::from_slice failing to check that the source IP is unicast and non-zero (both of which constitute invalid headers).

Given that we are using the Linux kernel as something of a reference implementation, we should make sure that we are enforcing as many of its constraints as possible.

I expect this ticket to stay open for a while, as it is quite a large job with no absolute proof that we are ever done.

That said, I think we should create sub-issues for this ticket on a per-header basis and do our best to take care of each one individually.

@daniel-noland daniel-noland added enhancement New feature or request meta labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta
Projects
None yet
Development

No branches or pull requests

1 participant