C#: Move parallelsink to the library qlpack.

Author: michaelnebel

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks/ParallelSink.qll

@@ -0,0 +1,24 @@
+import csharp
+
+abstract class ParallelSink extends DataFlow::Node { }
+
+class LambdaParallelSink extends ParallelSink {
+  LambdaParallelSink() {
+    exists(Class c, Method m, MethodCall mc, Expr e | e = this.asExpr() |
+      c.getABaseType*().hasFullyQualifiedName("System.Threading.Tasks", "Parallel") and
+      c.getAMethod() = m and
+      m.getName() = "Invoke" and
+      m.getACall() = mc and
+      mc.getAnArgument() = e
+    )
+  }
+}
+
+class ThreadStartParallelSink extends ParallelSink {
+  ThreadStartParallelSink() {
+    exists(DelegateCreation dc, Expr e | e = this.asExpr() |
+      dc.getArgument() = e and
+      dc.getType().getName().matches("%Start")
+    )
+  }
+}

csharp/ql/src/Likely Bugs/ParallelSink.qll

@@ -1,24 +1,6 @@
-import csharp
-
-abstract class ParallelSink extends DataFlow::Node { }
+/**
+ * DEPRECATED: Use `ParallelSink` from `flowsinks.ParallelSink` instead.
+ */
 
-class LambdaParallelSink extends ParallelSink {
-  LambdaParallelSink() {
-    exists(Class c, Method m, MethodCall mc, Expr e | e = this.asExpr() |
-      c.getABaseType*().hasFullyQualifiedName("System.Threading.Tasks", "Parallel") and
-      c.getAMethod() = m and
-      m.getName() = "Invoke" and
-      m.getACall() = mc and
-      mc.getAnArgument() = e
-    )
-  }
-}
-
-class ThreadStartParallelSink extends ParallelSink {
-  ThreadStartParallelSink() {
-    exists(DelegateCreation dc, Expr e | e = this.asExpr() |
-      dc.getArgument() = e and
-      dc.getType().getName().matches("%Start")
-    )
-  }
-}
+import csharp
+deprecated import semmle.code.csharp.security.dataflow.flowsinks.ParallelSink

csharp/ql/src/Likely Bugs/ThreadUnsafeICryptoTransformLambda.ql

@@ -15,7 +15,7 @@
  */
 
 import csharp
-import ParallelSink
+import semmle.code.csharp.security.dataflow.flowsinks.ParallelSink
 import ICryptoTransform
 
 module NotThreadSafeCryptoUsageIntoParallelInvokeConfig implements DataFlow::ConfigSig {