-
Notifications
You must be signed in to change notification settings - Fork 1k
Open
Description
✅ Cross-SDK Consistency Review
I've reviewed PR #731 for cross-SDK consistency across all four language implementations (Node.js/TypeScript, Python, Go, and .NET).
Summary: Excellent consistency maintained ✨
This PR successfully adds the blob attachment type to all four SDKs with proper feature parity:
Type Definitions ✅
- Node.js/TypeScript: Manual type added to
MessageOptions.attachmentsunion innodejs/src/types.ts+ generated types updated - Python:
BlobAttachmentTypedDict added topython/copilot/types.pyand properly exported in__init__.py+ generated types updated - Go: Uses generated
Attachmentstruct fromgenerated_session_events.gowithBlobAttachmentType constant - .NET:
UserMessageDataAttachmentsItemBlobclass generated indotnet/src/Generated/SessionEvents.cs
API Consistency ✅
All SDKs expose the same three required/optional fields with appropriate naming conventions:
| Field | Node/Python | Go | .NET | Required |
|---|---|---|---|---|
| data | data |
Data |
Data |
✅ |
| mimeType | mimeType |
MIMEType |
MimeType |
✅ |
| displayName | displayName |
DisplayName |
DisplayName |
Optional |
Documentation ✅
- Comprehensive examples added to all four language READMEs
- Detailed feature documentation in
docs/features/image-input.mdwith side-by-side examples - Updated
docs/features/streaming-events.mdto mention blob attachments - Test scenario documentation updated in
test/scenarios/prompts/attachments/README.md
No consistency issues found 🎉
The implementation properly accounts for language idioms (camelCase in TS/Python dict keys, PascalCase in Go/C# public APIs) while maintaining semantic equivalence across all SDKs.
Generated by SDK Consistency Review Agent for issue #731 · ◷
Originally posted by @github-actions[bot] in #731 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.