Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing actions in GitHub Marketplace doesn't say name should not include : #36546

Closed
1 task done
Tracked by #35423
jsoref opened this issue Feb 27, 2025 · 2 comments
Closed
1 task done
Tracked by #35423
Labels
content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 27, 2025

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/sharing-automations/creating-actions/publishing-actions-in-github-marketplace

What part(s) of the article would you like to see updated?

The sub-bullets under:

  • The name in the action's metadata file must be unique.

should include name should not include :

Additional information

https://github.com/marketplace/actions/nowsecure-mobile-sbom is a composite action on the marketplace
it corresponds to:
https://github.com/nowsecure/nowsecure-sbom-action/blob/main/action.yml

Clicking Use latest version yields:

Image

https://github.com/check-spelling-sandbox/stunning-bassoon/actions/runs/13566473746
https://github.com/check-spelling-sandbox/stunning-bassoon/actions/runs/13566473746/workflow

name: Mobile SBOM

on:
  push:

jobs:
  sbom:

    runs-on: ubuntu-latest
    permissions:
      contents: read

    steps:
      - name: NowSecure: Mobile SBOM

❌ Check failure on line 14 in .github/workflows/sbom.yml

GitHub Actions / .github/workflows/sbom.yml
Invalid workflow file

You have an error in your yaml syntax on line 14

        uses: nowsecure/nowsecure-sbom-action@v3

Obviously it would be best if the validator rejected this explicitly and the marketplace didn't have entries like this, but the easiest entrypoint I have to feedback is fixing the docs.

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Feb 27, 2025
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 27, 2025
@subatoi
Copy link
Contributor

subatoi commented Feb 27, 2025

Hi @jsoref

Obviously it would be best if the validator rejected this explicitly and the marketplace didn't have entries like this, but the easiest entrypoint I have to feedback is fixing the docs.

I agree, and I think the best outcome here would be for me to feed back internally about the lack of linting on the Marketplace, as I realise that's frustrating. From a docs perspective, this is a YAML syntax issue above all else and I don't think calling out one specific potential YAML error makes sense, so I'm going to close this out—but please rest assured that I will send that feedback to the Marketplace team. Thank you as ever for your help

@subatoi subatoi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

3 participants
@jsoref @subatoi and others