Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Repo Stale Check workflow incorrectly closes PRs right after adding stale label instead of after 3 days #36568

Closed
1 task done
rakleed opened this issue Feb 28, 2025 · 3 comments
Labels
content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team

Comments

@rakleed
Copy link
Contributor

rakleed commented Feb 28, 2025

Code of Conduct

What article on docs.github.com is affected?

https://github.com/github/docs/blob/main/.github/workflows/triage-stale-check.yml

What changes are you suggesting?

You can see it, for example, here: #35028 (comment) — the label stale is added, and then immediately the PR closes. Although, according to the description and judging by the code, this should happen 3 days after that:

stale-pr-message: 'A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.'
days-before-pr-stale: 7
days-before-pr-close: 3

Additional information

No response

@rakleed rakleed added the content This issue or pull request belongs to the Docs Content team label Feb 28, 2025
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 28, 2025
@subatoi
Copy link
Contributor

subatoi commented Feb 28, 2025

Hi @rakleed and thanks for opening this issue—in that particular PR's case, I suspect it may have something to do with the fact that the PR was marked as stale multiple times. If you can show me an example of a PR where that hasn't been the case, please feel free to (even if this issue is closed).

Either way, I'm going to let our engineering team know about this and ask them to triage it internally in case any action is required. Since we regularly monitor this repo manually—including those issues that have gone stale—there shouldn't be any impact on contributors and I'm going to close this out, but as I said, feel free to add other example(s) latterly.

Thanks again for your interest in the GitHub docs!

@subatoi subatoi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2025
@rakleed
Copy link
Contributor Author

rakleed commented Feb 28, 2025

@subatoi when this happened for the first time in this PR, the PR was also closed immediately after the assignment of the stale label: #35028 (comment).

Here is another example where the stale label was assigned only once, but the PR was also immediately closed: #35829 (comment).

@subatoi
Copy link
Contributor

subatoi commented Mar 3, 2025

@rakleed OK, thank you for pointing those out—I'll go ahead and create an issue for our engineering team, but we'll need to handle that internally to get to the bottom of it. As I said, fortunately there's no actual impact for contributors. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants