Commit 269ae83
fix: silently skip add_comment when no triggering context on schedule runs (#24131)
* Initial plan
* fix: silently skip add_comment when no triggering context (schedule runs)
- add_comment.cjs: add `skipped: true` to max count reached return so
exceeding the per-run comment limit is a graceful skip, not a failure
- safe_output_handler_manager.cjs: log all skipped messages (not just
code-push types) so add_comment skips are visible in CI logs; add a
"Skipped (no context or limit reached)" summary line for transparency
- add_comment.test.cjs: assert `skipped: true` on the max-count result
The core fix (returning skipped:true when target is "triggering" but no
issue/PR context exists, e.g. schedule runs) was already in place in
add_comment.cjs + safe_output_helpers.cjs. These changes improve logging
visibility and extend the skipped semantics to the max-count path.
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7679435a-c1b7-4a0c-b3d7-4204d76aafad
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>1 parent e92ff6b commit 269ae83
File tree
3 files changed
+9
-3
lines changed- actions/setup/js
3 files changed
+9
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
| 333 | + | |
333 | 334 | | |
334 | 335 | | |
335 | 336 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2027 | 2027 | | |
2028 | 2028 | | |
2029 | 2029 | | |
| 2030 | + | |
2030 | 2031 | | |
2031 | 2032 | | |
2032 | 2033 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
481 | 481 | | |
482 | 482 | | |
483 | 483 | | |
484 | | - | |
485 | | - | |
486 | | - | |
| 484 | + | |
487 | 485 | | |
488 | 486 | | |
489 | 487 | | |
| |||
1090 | 1088 | | |
1091 | 1089 | | |
1092 | 1090 | | |
| 1091 | + | |
1093 | 1092 | | |
1094 | 1093 | | |
1095 | 1094 | | |
| |||
1101 | 1100 | | |
1102 | 1101 | | |
1103 | 1102 | | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
1104 | 1108 | | |
1105 | 1109 | | |
1106 | 1110 | | |
| |||
0 commit comments