Skip to content

[step-names] Align step names in daily-model-inventory Copilot billing job and frontmatter skill installer with glossary/consistency #54141

Description

@github-actions

Step Name Alignment Issues

Analyzed the pre-built manifest at /tmp/gh-aw/agent/step-alignment-input.json (565 unique step names, ~40K instances across all .lock.yml files). Found 2 verified issues.


1. Priority: High — "Copilot" missing "GitHub" prefix in billing-placeholder job

Location: .github/workflows/daily-model-inventory.md, job collect_copilot_billing_models (lines 231, 253), compiled into .github/workflows/daily-model-inventory.lock.yml

Current step names:

  • Create placeholder for Copilot billing models
  • Upload Copilot billing models artifact

Why it conflicts: The glossary requires "GitHub Copilot CLI" (not "Copilot CLI") as the canonical name, and this same workflow file already fixed three sibling steps in the neighboring job to use the full "GitHub Copilot" form — Install GitHub Copilot SDK with bundled GitHub Copilot CLI, Fetch GitHub Copilot SDK model billing information, Upload GitHub Copilot SDK models artifact (lines 268, 276, 307). These two steps in the collect_copilot_billing_models job reference the same product (GitHub Copilot pricing/billing) but were missed, leaving an inconsistency within the same file.

Suggested replacement names:

  • Create placeholder for GitHub Copilot billing models
  • Upload GitHub Copilot billing models artifact

2. Priority: Medium — "Install frontmatter skill N" uses only an index, not the skill identifier

Location: pkg/workflow/compiler_activation_steps.go:248 (compiler-generated step name, loop over skillRefs), compiled into any workflow with skills: frontmatter (e.g. mattpocock-skills-reviewer.lock.yml, ponytail-reviewer.lock.yml, archivx-agentic-workflows-analyzer.lock.yml)

Current step names: Install frontmatter skill 1, Install frontmatter skill 2, ... Install frontmatter skill 5

Why it conflicts: Per the clarity standard ("would a new contributor understand what this step does?"), a numbered-only name gives no indication of which skill is being installed when a workflow declares multiple skills — a reader has to cross-reference the workflow's skills: frontmatter list to map index → skill. The actual skill identifier is already available in code as skillRef.Skill (passed to GH_AW_FRONTMATTER_SKILLS env var on the same step) but isn't used in the step name.

Suggested fix: Include the skill identifier in the name, e.g. Install frontmatter skill: <skillRef.Skill> (trimmed/shortened if it contains a long @sha suffix), falling back to the current numbered form only if the identifier is empty.


AI dictionary alignment summary

  • Terms reviewed: GitHub Copilot CLI, GitHub Copilot SDK (project glossary only).
  • Terms adopted: none new; existing glossary terms are correct as defined.
  • Conflicts resolved: none between glossary and AI Coding Dictionary; both findings are step-name-vs-glossary/clarity mismatches.

Note: issue #53903 previously flagged and fixed the "Copilot CLI"/"Copilot SDK" naming for three steps in this same file's other job — that fix was correctly applied, but the two placeholder-job steps above were not part of that fix and still need alignment.

Generated by 📋 Step Name Alignment · agent · 147.6 AIC · ⌖ 12 AIC · ⊞ 9.8K ·

  • expires on Aug 21, 2026, 8:14 PM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions