Warn when combining --panic-on-warnings and --exact-rowcount

ggilder · ggilder · commit 371aca288bbf · 2026-03-10T11:35:35.000-07:00
diff --git a/go/cmd/gh-ost/main.go b/go/cmd/gh-ost/main.go
@@ -316,6 +316,9 @@ func main() {
 	if migrationContext.CheckpointIntervalSeconds < 10 {
 		migrationContext.Log.Fatalf("--checkpoint-seconds should be >=10")
 	}
+	if migrationContext.CountTableRows && migrationContext.PanicOnWarnings {
+		migrationContext.Log.Warning("--exact-rowcount with --panic-on-warnings: row counts cannot be exact due to warning detection")
+	}
 
 	switch *cutOver {
 	case "atomic", "default", "":

Original file line number	Diff line number	Diff line change
`@@ -316,6 +316,9 @@ func main() {`
`316`	`316`	`if migrationContext.CheckpointIntervalSeconds < 10 {`
`317`	`317`	`migrationContext.Log.Fatalf("--checkpoint-seconds should be >=10")`
`318`	`318`	`}`
	`319`	`+ if migrationContext.CountTableRows && migrationContext.PanicOnWarnings {`
	`320`	`+ migrationContext.Log.Warning("--exact-rowcount with --panic-on-warnings: row counts cannot be exact due to warning detection")`
	`321`	`+ }`
`319`	`322`
`320`	`323`	`switch *cutOver {`
`321`	`324`	`case "atomic", "default", "":`