refactor: remove nprogress loading indicator (#1790)

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

Diff for: package.json

@@ -152,7 +152,6 @@
     "@testing-library/react": "16.2.0",
     "@types/jest": "29.5.14",
     "@types/node": "22.12.0",
-    "@types/nprogress": "0.2.3",
     "@types/react": "19.0.8",
     "@types/react-dom": "19.0.3",
     "@types/react-router-dom": "5.3.3",
@@ -174,7 +173,6 @@
     "jest-environment-jsdom": "29.7.0",
     "mini-css-extract-plugin": "2.9.2",
     "nock": "13.5.6",
-    "nprogress": "0.2.0",
     "postcss": "8.5.1",
     "postcss-loader": "8.1.1",
     "rimraf": "6.0.1",

Diff for: pnpm-lock.yaml

@@ -9,7 +9,6 @@ import {
 
 import { BaseStyles, Box, ThemeProvider } from '@primer/react';
 
-import { Loading } from './components/Loading';
 import { Sidebar } from './components/Sidebar';
 import { AppContext, AppProvider } from './context/App';
 import { AccountsRoute } from './routes/Accounts';
@@ -40,7 +39,6 @@ export const App = () => {
         <AppProvider>
           <Router>
             <Box className="flex flex-col min-h-screen overflow-x-hidden overflow-y-auto pl-sidebar bg-gitify-background">
-              <Loading />
               <Sidebar />
               <Routes>
                 <Route

Diff for: src/renderer/App.tsx

@@ -1,4 +1,4 @@
-import { fireEvent, render, screen } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import { type IRadioGroup, RadioGroup } from './RadioGroup';
 
 describe('renderer/components/fields/RadioGroup.tsx', () => {
@@ -24,12 +24,4 @@ describe('renderer/components/fields/RadioGroup.tsx', () => {
     const tree = render(<RadioGroup {...mockProps} />);
     expect(tree).toMatchSnapshot();
   });
-
-  it('should check that NProgress is getting called in getDerivedStateFromProps (loading)', () => {
-    render(<RadioGroup {...props} />);
-
-    fireEvent.click(screen.getByLabelText('Value 1'));
-
-    expect(props.onChange).toHaveBeenCalledTimes(1);
-  });
 });

Diff for: src/renderer/components/Loading.test.tsx

@@ -1,6 +1,5 @@
 import { createRoot } from 'react-dom/client';
 
-import 'nprogress/nprogress.css';
 import { App } from './App';
 
 const container = document.getElementById('root');