fix: discussions-url (#538)

Co-authored-by: Afonso Jorge Ramos <[email protected]>

Author: Araxeus

.gitignore

@@ -73,3 +73,4 @@ temp/
 
 dist/
 build/
+.vscode/settings.json

package.json

@@ -125,7 +125,7 @@
     "react-transition-group": "^4.4.1",
     "tailwindcss": "^2.0.2",
     "ts-loader": "^9.4.2",
-    "typescript": "^4.1.3"
+    "typescript": "^4.6.2"
   },
   "devDependencies": {
     "@testing-library/react": "^11.2.2",

pnpm-lock.yaml

@@ -27,27 +27,35 @@ window.localStorage = {
 
 window.alert = jest.fn();
 
-const browserWindow = {
-  loadURL: jest.fn(),
-  webContents: {
+let instance;
+
+class BrowserWindow {
+  constructor() {
+    if (!instance) {
+      instance = this;
+    }
+    return instance;
+  }
+  loadURL = jest.fn();
+  webContents = {
     on: () => {},
     session: {
       clearStorageData: jest.fn(),
     },
-  },
-  on: () => {},
-  close: jest.fn(),
-  hide: jest.fn(),
-  destroy: jest.fn(),
-};
+  };
+  on() {}
+  close = jest.fn();
+  hide = jest.fn();
+  destroy = jest.fn();
+}
 
 const dialog = {
   showErrorBox: jest.fn(),
 };
 
 module.exports = {
   remote: {
-    BrowserWindow: () => browserWindow,
+    BrowserWindow: BrowserWindow,
     dialog: dialog,
     process: {
       platform: 'darwin',
@@ -57,7 +65,7 @@ module.exports = {
       getLoginItemSettings: jest.fn(),
       setLoginItemSettings: () => {},
     },
-    getCurrentWindow: jest.fn(() => browserWindow),
+    getCurrentWindow: jest.fn(() => instance || new BrowserWindow()),
   },
   ipcRenderer: {
     send: jest.fn(),

src/__mocks__/electron.js

@@ -1,5 +1,5 @@
 import { AccountNotifications, EnterpriseAccount } from '../types';
-import { Notification, Repository, User } from '../typesGithub';
+import { Notification, Repository, User, GraphQLSearch } from '../typesGithub';
 
 export const mockedEnterpriseAccounts: EnterpriseAccount[] = [
   {
@@ -274,3 +274,116 @@ export const mockedSingleAccountNotifications: AccountNotifications[] = [
     notifications: [mockedSingleNotification],
   },
 ];
+
+export const mockedGraphQLResponse: GraphQLSearch = {
+  data: {
+    data: {
+      search: {
+        edges: [
+          {
+            node: {
+              viewerSubscription: 'SUBSCRIBED',
+              title: '1.16.0',
+              url: 'https://github.com/manosim/notifications-test/discussions/612',
+              comments: {
+                edges: [
+                  {
+                    node: {
+                      databaseId: 2215656,
+                      createdAt: '2022-02-20T18:33:39Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2217789,
+                      createdAt: '2022-02-21T03:30:42Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2223243,
+                      createdAt: '2022-02-21T18:26:27Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2232922,
+                              createdAt: '2022-02-23T00:57:58Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2232921,
+                      createdAt: '2022-02-23T00:57:49Z',
+                      replies: {
+                        edges: [],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2258799,
+                      createdAt: '2022-02-27T01:22:20Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300902,
+                              createdAt: '2022-03-05T17:43:52Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2297637,
+                      createdAt: '2022-03-04T20:39:44Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300893,
+                              createdAt: '2022-03-05T17:41:04Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                  {
+                    node: {
+                      databaseId: 2299763,
+                      createdAt: '2022-03-05T11:05:42Z',
+                      replies: {
+                        edges: [
+                          {
+                            node: {
+                              databaseId: 2300895,
+                              createdAt: '2022-03-05T17:41:44Z',
+                            },
+                          },
+                        ],
+                      },
+                    },
+                  },
+                ],
+              },
+            },
+          },
+        ],
+      },
+    },
+  },
+};

src/__mocks__/mockedData.ts

@@ -1,11 +1,9 @@
-const { shell } = require('electron');
-
 import React, { useCallback, useContext } from 'react';
 import { formatDistanceToNow, parseISO } from 'date-fns';
 import { CheckIcon, MuteIcon } from '@primer/octicons-react';
 
 import { formatReason, getNotificationTypeIcon } from '../utils/github-api';
-import { generateGitHubWebUrl } from '../utils/helpers';
+import { openInBrowser } from '../utils/helpers';
 import { Notification } from '../typesGithub';
 import { AppContext } from '../context/App';
 
@@ -18,8 +16,8 @@ export const NotificationRow: React.FC<IProps> = ({
   notification,
   hostname,
 }) => {
-  const { settings, accounts } = useContext(AppContext);
-  const { markNotification, unsubscribeNotification } = useContext(AppContext);
+  const { settings, accounts, markNotification, unsubscribeNotification } =
+    useContext(AppContext);
 
   const pressTitle = useCallback(() => {
     openBrowser();
@@ -29,17 +27,10 @@ export const NotificationRow: React.FC<IProps> = ({
     }
   }, [settings]);
 
-  const openBrowser = useCallback(() => {
-    // Some Notification types from GitHub are missing urls in their subjects.
-    if (notification.subject.url) {
-      const url = generateGitHubWebUrl(
-        notification.subject.url,
-        notification.id,
-        accounts.user?.id
-      );
-      shell.openExternal(url);
-    }
-  }, [notification]);
+  const openBrowser = useCallback(
+    () => openInBrowser(notification, accounts),
+    [notification]
+  );
 
   const unsubscribe = (event: React.MouseEvent<HTMLElement>) => {
     // Don't trigger onClick of parent element.

src/components/NotificationRow.tsx

@@ -98,12 +98,7 @@ export const useNotifications = (): NotificationsState => {
                 ]
               : [...enterpriseNotifications];
 
-            triggerNativeNotifications(
-              notifications,
-              data,
-              settings,
-              accounts.user
-            );
+            triggerNativeNotifications(notifications, data, settings, accounts);
             setNotifications(data);
             setIsFetching(false);
           })

src/hooks/useNotifications.ts

@@ -84,7 +84,7 @@ exports[`routes/LoginWithToken.js renders correctly 1`] = `
           <span
             className="underline font-extrabold text-yellow-500"
           >
-            read:user, notifications
+            read:user, notifications, repo
              
           </span>
           scopes.