Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add a new "Mark as done on click" setting #714

Closed
adufr opened this issue Jan 19, 2024 · 5 comments
Closed

Feature request: add a new "Mark as done on click" setting #714

adufr opened this issue Jan 19, 2024 · 5 comments
Assignees
Labels
enhancement New feature or enhancement to existing functionality

Comments

@adufr
Copy link
Contributor

adufr commented Jan 19, 2024

📝 Provide a description of the new feature

This feature would be possible thanks to the newly added Mark notification as done API endpoint (see #500)

It would basically do the same thing than the old Mark notification as read on click setting which is now obsolete (#712)

➕ Additional Information

I'm willing to implement this, but I'd like my other PR #500 to be merged before as it will use shared code/functions (I might open a stacked PR..)

@rpuncel
Copy link

rpuncel commented Jan 26, 2024

This would be hugely helpful; GitIfy is super useful but the "Done" feature in GitHub Notification Center is critical for me. Right now, I'll let Gitify make me aware there's a notification, but then still open the GitHub Notification center to actually read the notification.

@adufr
Copy link
Contributor Author

adufr commented Feb 7, 2024

I'm closing this as the feature has been merged 🎉

@adufr adufr closed this as completed Feb 7, 2024
@setchy setchy added enhancement New feature or enhancement to existing functionality and removed feature-request labels Feb 29, 2024
@fredrikaverpil
Copy link

Was there ever a release that included this feature?

@adufr
Copy link
Contributor Author

adufr commented Mar 8, 2024

@fredrikaverpil not yet :(

@setchy
Copy link
Member

setchy commented Mar 8, 2024

@fredrikaverpil @adufr - we need to fix this before our next release #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants