Skip to content

PR autolink patterns like pull request # link to an issue of that number instead #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergeibbb opened this issue Mar 31, 2025 · 1 comment · Fixed by #4233
Closed

PR autolink patterns like pull request # link to an issue of that number instead #4193

sergeibbb opened this issue Mar 31, 2025 · 1 comment · Fixed by #4233
Assignees
@sergeibbb
Labels
needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Milestone
17.1

Comments

@sergeibbb
Copy link
Member

sergeibbb commented Mar 31, 2025 •
edited
Loading

Description

Verification steps

  1. Create two commits: one links to a ticket another one links to an issue with the same number.
  2. Look at autolinks of one commit and of another commit. They should have right autolinks: to the PR and to the issue.

GitLens Version

16.3.3 pre-release

VS Code Version

No response

Git Version

No response

Logs, Screenshots, Screen Captures, etc

No response
@sergeibbb sergeibbb added the triage Needs to be looked at label Mar 31, 2025
@sergeibbb sergeibbb added this to the 17.0-patch milestone Mar 31, 2025
@sergeibbb sergeibbb self-assigned this Mar 31, 2025
@sergeibbb sergeibbb mentioned this issue Mar 31, 2025
Closed
9 tasks
@eamodio eamodio modified the milestones: 17.0-patch, 17.0, 17.1 Apr 1, 2025
@sergeibbb
Copy link
Member Author

sergeibbb commented Apr 14, 2025 •
edited
Loading

I don't see this exact behavior. My PR link links to a PR:

Image

but, I see a vise versa: my issue link links to a PR instead of an issue:

Image

and wrong title on the tooltip:

Image

@sergeibbb sergeibbb removed the triage Needs to be looked at label Apr 14, 2025
sergeibbb added a commit that referenced this issue Apr 14, 2025
@sergeibbb
Adds AutolinkType to cache keys for issue/PR retrieval
55a42b3 
preventing potential cache collisions.
(#4193)
@sergeibbb sergeibbb linked a pull request Apr 14, 2025 that will close this issue
Adds IssueOrPullRequestType to cache keys for issue/PR retrieval #4233
Merged
7 tasks
@sergeibbb sergeibbb mentioned this issue Apr 14, 2025
Merged
7 tasks
sergeibbb added a commit that referenced this issue Apr 14, 2025
@sergeibbb
Adds AutolinkType to cache keys for issue/PR retrieval
a03056a 
preventing potential cache collisions.
(#4193, #4233)
sergeibbb added a commit that referenced this issue Apr 14, 2025
@sergeibbb
Adds AutolinkType to cache keys for issue/PR retrieval
fffa889 
preventing potential cache collisions.
(#4193, #4233)
sergeibbb added a commit that referenced this issue Apr 17, 2025
@sergeibbb
Adds AutolinkType to cache keys for issue/PR retrieval
628fed7 
preventing potential cache collisions.
(#4193, #4233)
sergeibbb added a commit that referenced this issue Apr 17, 2025
@sergeibbb
Adds IssueOrPullRequestType to cache keys for issue/PR retrieval
cb2026e 
preventing potential cache collisions.
(#4193, #4233)
sergeibbb added a commit that referenced this issue Apr 17, 2025
@sergeibbb
Adds IssueOrPullRequestType to cache keys for issue/PR retrieval
d798bfd 
preventing potential cache collisions.
(#4193, #4233)
@github-actions github-actions bot added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeibbb sergeibbb

Labels
needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Projects
None yet
Milestone
17.1
Development

Successfully merging a pull request may close this issue.

Adds IssueOrPullRequestType to cache keys for issue/PR retrieval gitkraken/vscode-gitlens
2 participants
@eamodio @sergeibbb