[stripe] Check for err when reporting stripe requests completed metric

easyCZ · roboquat · commit 72a01c02f18c · 2022-10-11T16:45:26.000+02:00
diff --git a/components/usage/pkg/stripe/reporter.go b/components/usage/pkg/stripe/reporter.go
@@ -64,9 +64,12 @@ func reportStripeRequestStarted(resource string) {
 }
 
 func reportStripeRequestCompleted(resource string, err error, took time.Duration) {
-	code := "unknown"
-	if stripeErr, ok := err.(*stripe.Error); ok {
-		code = string(stripeErr.Code)
+	code := "ok"
+	if err != nil {
+		code = "unknown"
+		if stripeErr, ok := err.(*stripe.Error); ok {
+			code = string(stripeErr.Code)
+		}
 	}
 
 	stripeClientRequestsCompletedSeconds.WithLabelValues(resource, code).Observe(took.Seconds())

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,12 @@ func reportStripeRequestStarted(resource string) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`func reportStripeRequestCompleted(resource string, err error, took time.Duration) {`
`67`		`- code := "unknown"`
`68`		`- if stripeErr, ok := err.(*stripe.Error); ok {`
`69`		`- code = string(stripeErr.Code)`
	`67`	`+ code := "ok"`
	`68`	`+ if err != nil {`
	`69`	`+ code = "unknown"`
	`70`	`+ if stripeErr, ok := err.(*stripe.Error); ok {`
	`71`	`+ code = string(stripeErr.Code)`
	`72`	`+ }`
`70`	`73`	`}`
`71`	`74`
`72`	`75`	`stripeClientRequestsCompletedSeconds.WithLabelValues(resource, code).Observe(took.Seconds())`