Add UploadFile method to contentservice client

Make the `GetSignedUploadUrl` method unexported and remove it from the
interface.

Compress reports before uploading to obj storage

* Stop writing the usage report to disk.
* Compress the report in memory.
* Upload the compressed report to object storage.

Author: Andrew Farries

components/usage/pkg/contentservice/client.go

@@ -7,14 +7,17 @@ package contentservice
 import (
 	"context"
 	"fmt"
+	"io"
+	"net/http"
 
+	"github.com/gitpod-io/gitpod/common-go/log"
 	"github.com/gitpod-io/gitpod/content-service/api"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials/insecure"
 )
 
 type Interface interface {
-	GetSignedUploadUrl(ctx context.Context) (string, error)
+	UploadFile(ctx context.Context, filename string, body io.Reader) error
 }
 
 type Client struct {
@@ -25,7 +28,33 @@ func New(url string) *Client {
 	return &Client{url: url}
 }
 
-func (c *Client) GetSignedUploadUrl(ctx context.Context) (string, error) {
+func (c *Client) UploadFile(ctx context.Context, filename string, body io.Reader) error {
+	url, err := c.getSignedUploadUrl(ctx, filename)
+	if err != nil {
+		return fmt.Errorf("failed to obtain signed upload URL: %w", err)
+	}
+
+	req, err := http.NewRequest(http.MethodPut, url, body)
+	if err != nil {
+		return fmt.Errorf("failed to construct http request: %w", err)
+	}
+
+	req.Header.Set("Content-Encoding", "gzip")
+
+	log.Infof("Uploading %q to object storage...", filename)
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return fmt.Errorf("failed to make http request: %w", err)
+	}
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("unexpected http response code: %s", resp.Status)
+	}
+	log.Info("Upload complete")
+
+	return nil
+}
+
+func (c *Client) getSignedUploadUrl(ctx context.Context, key string) (string, error) {
 	conn, err := grpc.Dial(c.url, grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		return "", fmt.Errorf("failed to dial content-service gRPC server: %w", err)
@@ -34,9 +63,9 @@ func (c *Client) GetSignedUploadUrl(ctx context.Context) (string, error) {
 
 	uc := api.NewUsageReportServiceClient(conn)
 
-	resp, err := uc.UploadURL(ctx, &api.UsageReportUploadURLRequest{Name: "some-name"})
+	resp, err := uc.UploadURL(ctx, &api.UsageReportUploadURLRequest{Name: key})
 	if err != nil {
-		return "", fmt.Errorf("failed to obtain signed upload URL: %w", err)
+		return "", fmt.Errorf("failed RPC to content service: %w", err)
 	}
 
 	return resp.Url, nil

components/usage/pkg/contentservice/noop.go

@@ -4,8 +4,13 @@
 
 package contentservice
 
-import "context"
+import (
+	"context"
+	"io"
+)
 
 type NoOpClient struct{}
 
-func (c *NoOpClient) GetSignedUploadUrl(ctx context.Context) (string, error) { return "", nil }
+func (c *NoOpClient) UploadFile(ctx context.Context, filename string, body io.Reader) error {
+	return nil
+}

components/usage/pkg/controller/reconciler.go

@@ -5,14 +5,13 @@
 package controller
 
 import (
+	"bytes"
+	"compress/gzip"
 	"context"
 	"database/sql"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
 	"math"
-	"os"
-	"path/filepath"
 	"time"
 
 	"github.com/gitpod-io/gitpod/common-go/log"
@@ -76,36 +75,26 @@ func (u *UsageReconciler) Reconcile() (err error) {
 	}
 	log.WithField("usage_reconcile_status", status).Info("Reconcile completed.")
 
-	// For now, write the report to a temp directory so we can manually retrieve it
-	dir := os.TempDir()
-	f, err := ioutil.TempFile(dir, fmt.Sprintf("%s-*", now.Format(time.RFC3339)))
-	if err != nil {
-		return fmt.Errorf("failed to create temporary file: %w", err)
-	}
-	defer f.Close()
-
-	enc := json.NewEncoder(f)
-	err = enc.Encode(report)
+	reportBytes := &bytes.Buffer{}
+	gz := gzip.NewWriter(reportBytes)
+	err = json.NewEncoder(gz).Encode(report)
 	if err != nil {
 		return fmt.Errorf("failed to marshal report to JSON: %w", err)
 	}
-
-	stat, err := f.Stat()
-	filePath := filepath.Join(dir, stat.Name())
+	err = gz.Close()
 	if err != nil {
-		return fmt.Errorf("failed to get file stats: %w", err)
+		return fmt.Errorf("failed to compress usage report: %w", err)
 	}
-	log.Infof("Wrote usage report into %s", filePath)
 
-	uploadURL, err := u.contentService.GetSignedUploadUrl(ctx)
+	err = db.CreateUsageRecords(ctx, u.conn, usageReportToUsageRecords(report, u.pricer, u.nowFunc().UTC()))
 	if err != nil {
-		return fmt.Errorf("failed to obtain signed upload URL: %w", err)
+		return fmt.Errorf("failed to write usage records to database: %s", err)
 	}
-	log.Infof("signed upload url: %s", uploadURL)
 
-	err = db.CreateUsageRecords(ctx, u.conn, usageReportToUsageRecords(report, u.pricer, u.nowFunc().UTC()))
+	filename := fmt.Sprintf("%s.gz", now.Format(time.RFC3339))
+	err = u.contentService.UploadFile(ctx, filename, reportBytes)
 	if err != nil {
-		return fmt.Errorf("failed to write usage records to database: %s", err)
+		return fmt.Errorf("failed to upload usage report: %w", err)
 	}
 
 	return nil