Rename --api-key-file to --stripe-secret-path

Author: Andrew Farries

components/usage/cmd/run.go

@@ -79,7 +79,7 @@ func run() *cobra.Command {
 
 	cmd.Flags().BoolVar(&verbose, "verbose", false, "Toggle verbose logging (debug level)")
 	cmd.Flags().DurationVar(&schedule, "schedule", 1*time.Hour, "The schedule on which the reconciler should run")
-	cmd.Flags().StringVar(&apiKeyFile, "api-key-file", "", "Location of the Stripe credentials file on disk")
+	cmd.Flags().StringVar(&apiKeyFile, "stripe-secret-path", "", "Location of the Stripe credentials file on disk")
 
 	return cmd
 }

install/installer/pkg/components/usage/deployment.go

@@ -50,7 +50,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
 				ReadOnly:  true,
 			})
 
-			args = append(args, fmt.Sprintf("--api-key-file=%s", filepath.Join(stripeSecretMountPath, stripeKeyFilename)))
+			args = append(args, fmt.Sprintf("--stripe-secret-path=%s", filepath.Join(stripeSecretMountPath, stripeKeyFilename)))
 		}
 		return nil
 	})

install/installer/pkg/components/usage/deployment_test.go

@@ -65,7 +65,7 @@ func TestDeployment_EnablesPaymentWhenAStripeSecretIsPresent(t *testing.T) {
 	require.Len(t, containers, 2)
 
 	usageContainer := containers[0]
-	expectedArgument := fmt.Sprintf("--api-key-file=%s", filepath.Join(stripeSecretMountPath, stripeKeyFilename))
+	expectedArgument := fmt.Sprintf("--stripe-secret-path=%s", filepath.Join(stripeSecretMountPath, stripeKeyFilename))
 
 	require.Contains(t, usageContainer.Args, expectedArgument)
 }
@@ -85,6 +85,6 @@ func TestDeployment_DisablesPaymentWhenAStripeSecretIsNotPresent(t *testing.T) {
 	usageContainer := containers[0]
 
 	for _, arg := range usageContainer.Args {
-		require.NotContains(t, arg, "--api-key-file")
+		require.NotContains(t, arg, "--stripe-secret-path")
 	}
 }