Skip to content

Hide unused ports from ports view(s) #10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loujaybee opened this issue Jun 1, 2022 · 3 comments · Fixed by #13788
Open

Hide unused ports from ports view(s) #10408

loujaybee opened this issue Jun 1, 2022 · 3 comments · Fixed by #13788

Comments

@loujaybee
Copy link
Member

Introduce alternative port state / hide unused ports from list.

Currently, the port states we have are:

  1. open - private
  2. open - public
  3. not served

This last category not served contains three types of ports (that I can think of):

  1. Those defined in YAML - but not currently served - These could be marked differently, e.g. configured - not served
  2. Those not defined in YAML, but are required - e.g. user has opened them previously, marked as public, and is starting/stopping a process, e.g. not configured - not served.
  3. Not defined in YAML - not required - There is currently no way to clean up these ports.

By grouping these all together, it's hard to distinguish between each, it also means that we're not encouraging users to update the gitpod.yml where necessary (and push users to config their environment as much as possible).

Potential options/solutions:

  1. Break down the not served state to be more explicit
  2. Hide all not served ports by default, and only show when served, however allow the user to show them if passing a specific flag to CLI (e.g. gp ports --all) and using a filter in the UI, similar to how dotfiles hide/show when using ls vs ls -a

This issue relates to: #10275

Example of enabling a number of ports, and them continuing to show in the ports list.

image

@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 16, 2022
@mustard-mh mustard-mh added the meta: never-stale This issue can never become stale label Oct 20, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 20, 2022
@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 20, 2022

Close as #13788 fixed this PR only hides not served and not defined in .gitpod.yml 's ports

@akosyakov
Copy link
Member

See #14070 (comment) for why we decided to not hide for now. Smarter strategy is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants