Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): remove function body alias and use block #111

Merged

Conversation

rawhat
Copy link
Contributor

@rawhat rawhat commented Feb 6, 2025

This closes #110

Let me know if I misunderstood what you meant about the alias. The test updates make sense to me, though I don't fully understand the (MISSING "todo") part 😅. It seems to work as expected in neovim, anyway.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@the-mikedavis the-mikedavis merged commit 3a5c285 into gleam-lang:main Feb 7, 2025
3 checks passed
@clason
Copy link

clason commented Feb 8, 2025

This is not a "fix" but a breaking change since it removes the function_body node, breaking existing queries that use it (like those in nvim-treesitter). Please try to adhere to parser semver and conventional commits for the sake of downstream projects.

@rawhat
Copy link
Contributor Author

rawhat commented Feb 8, 2025

This is not a "fix" but a breaking change since it removes the function_body node, breaking existing queries that use it (like those in nvim-treesitter). Please try to adhere to parser semver and conventional commits for the sake of downstream projects.

My fault, sorry about that. I can open a PR to nvim-treesitter to update the query. I'll be sure to mark things as breaking changes in the future.

@clason
Copy link

clason commented Feb 8, 2025

I already fixed it, thanks. But, yes, that would be appreciated in the future.

@rawhat
Copy link
Contributor Author

rawhat commented Feb 8, 2025

I already fixed it, thanks. But, yes, that would be appreciated in the future.

Thank you 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the (anonymous) function body include brackets?
3 participants