Skip to content

Commit f6b63df

Browse files
committed
Fix issue #523 - "Slider cannot be initialized in iframe #523"
1 parent 87b3be2 commit f6b63df

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/components/html.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default function (Glide, Components, Events) {
4848
r = document.querySelector(r)
4949
}
5050

51-
if (r !== null) {
51+
if (exist(r)) {
5252
Html._r = r
5353
} else {
5454
warn('Root element must be a existing Html node')

src/utils/dom.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ export function siblings (node) {
2828
* @return {Boolean}
2929
*/
3030
export function exist (node) {
31-
if (node && node instanceof window.HTMLElement) {
31+
// We are usine duck-typing here because we can't use `instanceof` since if we're in an iframe the class instance will be different.
32+
if (node && node.appendChild && node.isConnected) {
3233
return true
3334
}
3435

0 commit comments

Comments
 (0)