We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort
cursory git bisect points at the rewrites in commit 0a8a035 shortly after the initial sort test. sort might've been broken since then(?)
installed glj at latest via go install.
go install
This seems like this was (is?) passing in this test
glojure/pkg/runtime/testdata/eval/sort00.glj
Line 2 in bada110
user=> (sort [3 2 1]) ToSlice not supported on type: *lang.Vector GLJ Stack: glojure/core.glj:3092:14: (to-array coll) glojure/core.glj:3089:4: (sort compare coll) repl:1:1: (sort [3 2 1])
user=> (sort '(3 2 1)) unable to resolve symbol: java.util.Arrays Stack trace (most recent call first): <unknown>:?:? GLJ Stack: glojure/core.glj:3089:4: (sort compare coll) repl:1:1: (sort (quote (3 2 1)))
Happy to take a look with pointers
The text was updated successfully, but these errors were encountered:
Thanks for the report! If you want to take a stab at it:
ToSlice should support more than just ISeqs. We'll want to match Clojure's toArray behavior.
ISeq
We need a rewrite rule that maps (. java.util.Arrays (sort a comp)) to an equivalent call to sort.Slice
(. java.util.Arrays (sort a comp))
sort.Slice
Sorry, something went wrong.
Fix sort fails for lists and vectors (glojurelang#66)
82ac3bf
No branches or pull requests
cursory git bisect points at the rewrites in commit 0a8a035 shortly after the initial sort test. sort might've been broken since then(?)
Context
installed glj at latest via
go install
.This seems like this was (is?) passing in this test
glojure/pkg/runtime/testdata/eval/sort00.glj
Line 2 in bada110
Error
Happy to take a look with pointers
The text was updated successfully, but these errors were encountered: